fixed setRoute behaviour#297
Closed
merrifieldbrian wants to merge 5 commits intoflatiron:masterfrom
merrifieldbrian:master
Closed
fixed setRoute behaviour#297merrifieldbrian wants to merge 5 commits intoflatiron:masterfrom merrifieldbrian:master
merrifieldbrian wants to merge 5 commits intoflatiron:masterfrom
merrifieldbrian:master
Conversation
|
This can be squashed into one commit (since the second commit fixes a bug in the first), and I'd prefer for the check for But yeah, this totally needs to be merged, especially since the documentation indicates that this behavior should already be implemented. |
Author
|
created new pr (#314) to squash extra commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added splice route ability as specified in ReadMe. (#235)
Also fixed typo on line 225 where 's' is used instead of 'val'