Skip to content

fixed setRoute behaviour#297

Closed
merrifieldbrian wants to merge 5 commits intoflatiron:masterfrom
merrifieldbrian:master
Closed

fixed setRoute behaviour#297
merrifieldbrian wants to merge 5 commits intoflatiron:masterfrom
merrifieldbrian:master

Conversation

@merrifieldbrian
Copy link
Copy Markdown

Added splice route ability as specified in ReadMe. (#235)
Also fixed typo on line 225 where 's' is used instead of 'val'

@asazernik
Copy link
Copy Markdown

This can be squashed into one commit (since the second commit fixes a bug in the first), and I'd prefer for the check for typeof val == 'string' to only be done if the first two arguments are integers. Otherwise we'll call to splice with e.g. setRoute("some", "garbage", "arguments") and give a really unhelpful error message.

But yeah, this totally needs to be merged, especially since the documentation indicates that this behavior should already be implemented.

@merrifieldbrian
Copy link
Copy Markdown
Author

created new pr (#314) to squash extra commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants