feat: use tx hash instead of nonce to determine if the tx is a mempool tx#124
Open
0xdapper wants to merge 8 commits intoflashbots:masterfrom
Open
feat: use tx hash instead of nonce to determine if the tx is a mempool tx#1240xdapper wants to merge 8 commits intoflashbots:masterfrom
0xdapper wants to merge 8 commits intoflashbots:masterfrom
Conversation
* fix issue with geth not shutting down (flashbots#97) * Add eth_callBundle rpc method (flashbots#14) * flashbots: add eth_estimateGasBundle (flashbots#102) * feat(ethash): flashbots_getWork RPC with profit (flashbots#106) * Calculate megabundle as soon as it's received (flashbots#112) * Add v0.5 specification link (flashbots#118)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using nonce to determine is a rather naive way to compare txs. There can be a different tx with same nonce in the mempool. Searchers could want to send same txs with different gas prices(different tx hashes) to the mempool from their EOAs. They could be capturing different opportunities altogether at same nonce too. Nonce cannot be used in place of a tx hash.