Add option to config time to inclusion bucket size#498
Merged
zeroXbrock merged 4 commits intoflashbots:mainfrom Mar 27, 2026
Merged
Add option to config time to inclusion bucket size#498zeroXbrock merged 4 commits intoflashbots:mainfrom
zeroXbrock merged 4 commits intoflashbots:mainfrom
Conversation
gligneul
force-pushed
the
time-to-inclusion-buckets
branch
from
d51ad9f to
0bf9712
Compare
The time-to-inclusion chart in the generated reports previously used a fixed 1-second bucket size. This adds a `--time-to-inclusion-bucket <MS>` flag to the report and campaign subcommands to control the bucket size in milliseconds. Set the default to 1000 ms (1 second) to keep backward compatibility. Close flashbots#497
zeroXbrock
reviewed
Mar 26, 2026
Member
There was a problem hiding this comment.
some code suggestions applied in this PR: gligneul#1
Just future-prepping to prevent param overload. Code changes look good! Thank you 🙏
zeroXbrock
approved these changes
Mar 27, 2026
Member
zeroXbrock
left a comment
zeroXbrock
left a comment
There was a problem hiding this comment.
nice work, thanks @gligneul !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The time-to-inclusion chart in the generated reports previously used a fixed 1-second bucket size, which was too small for fast chains.
Solution
This adds a
--time-to-inclusion-bucket <MS>flag to the report and campaign subcommands to control the bucket size in milliseconds. Set the default to 1000 ms (1 second) to keep backward compatibility.PR Checklist
cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fixcargo fmt --allCHANGELOG.mdin each affected crateClose #497