[Highlight]: Changed guild highlights & black formatting#242
Closed
Evanroby wants to merge 2 commits intoflaree:masterfrom
Closed
[Highlight]: Changed guild highlights & black formatting#242Evanroby wants to merge 2 commits intoflaree:masterfrom
Evanroby wants to merge 2 commits intoflaree:masterfrom
Conversation
I made that guild highlights are only working if the user that added an highlight can see the channel. I heard it is against TOS to let the highlight in channels we cannot see.
for more information, see https://pre-commit.ci
Owner
|
Im struggling to actually understand this PR, what does it actually do? Guild highlights already check permissions, line 202. If a user cannot see a channel they wont get a dm |
Contributor
Author
|
some peoples asked me for this, they told me they already got one dm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made that guild highlights are only working if the user that added an highlight can see the channel. I heard it is against TOS to let the highlight in channels we cannot see.
Also black reformatted everything, and changed the docstring a little to make it more clear (nvm, pre-commit reverted).
On line 44, I made the
min_len4 instead of 5, I think it is better that way.I have tested the changes, it works like expected.
Thanks for looking! Real code changes starts from line
777, everything else is automatic reformat.