Support the new distribution handshake#14
Open
igoralmeida wants to merge 2 commits intoflambard:masterfrom
Open
Support the new distribution handshake#14igoralmeida wants to merge 2 commits intoflambard:masterfrom
igoralmeida wants to merge 2 commits intoflambard:masterfrom
Conversation
Tested only `perform-client-handshake` with iex, not `perform-server-handshake`. I have also not tested every capability, the added flags seem to be the bare minimum to avoid a rejection from elixir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR allows CLERIC to connect to elixir once again. It does so by using the new handshake messages and pretending that it supports all the capabilities
iexrequires.I haven't tested this thoroughly because I don't fully understand what each capability means.
It is possible, however, to (a) connect to iex with
remote-node-connect; (b) send messages usingreg-send; and (c) receive messages withreceive-node-messages. Doing these things requires flambard/cl-erlang-term#7Like the other PR, this is not really intended to be merged as-is, more for gathering comments and preventing bit-rot.
Cheers