Conversation
This reverts commit 6470d81.
Gawor270
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the root TypeScript typecheck script so that typecheck failures correctly propagate a non-zero exit code (e.g., in CI), instead of being masked.
Changes:
- Remove the
|| echo ...fallback from the roottscscript so failures cause the command to fail.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AHGIJMKLKKZNPJKQR
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed echo print indicating test failed from
yarn tscwhich caused to return command to exit always with 0 which is interpreted as passed testMotivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)