Skip to content

FDS Source: Fix condensation kappa issue and adjust verification exact #16096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drjfloyd merged 2 commits into from
Mar 26, 2026
+21 −10
Merged

FDS Source: Fix condensation kappa issue and adjust verification exact #16096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6c1d4b
Merge remote-tracking branch 'github/master'
drjfloyd Mar 25, 2026
c33b760
FDS Source: Fix condensation kappa issue and adjust verification exact
drjfloyd Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions Source/radi.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2766,14 +2766,15 @@ MODULE RAD
PUBLIC INIT_RADIATION,COMPUTE_RADIATION,BLACKBODY_FRACTION

REAL(EB) :: TYY_FAC
INTEGER :: N_KAPPA_T=44 !< Number of temperature points in absorption coefficient look-up table
INTEGER :: N_KAPPA_X=50 !< Number of species points in absorption coefficient look-up table
REAL(EB):: KAPPA_X_MIN=1.E-5_EB,KAPPA_X_MAX=1._EB !< Min/max volume fraction for absorption coefficient look-up table
REAL(EB):: KAPPA_C_MIN=2.E-7_EB,KAPPA_C_MAX=0.2_EB !< Min/Max mass fraction for soot coefficient look-up table
REAL(EB):: KAPPA_X_FAC,LOG_KAPPA_X_FAC !< Scaling factor for absorption coefficient look-up table
REAL(EB):: KAPPA_C_FAC,LOG_KAPPA_C_FAC !< Scaling factor for soot coefficient look-up table
INTEGER :: N_KAPPA_T=44 !< Number of temperature points in absorption coefficient look-up table
INTEGER :: N_KAPPA_X=50 !< Number of species points in absorption coefficient look-up table
REAL(EB) :: KAPPA_X_MIN=1.E-5_EB,KAPPA_X_MAX=1._EB !< Min/max volume fraction for absorption coefficient look-up table
REAL(EB) :: KAPPA_C_MIN=2.E-7_EB,KAPPA_C_MAX=0.2_EB !< Min/Max mass fraction for soot coefficient look-up table
REAL(EB) :: KAPPA_X_FAC,LOG_KAPPA_X_FAC !< Scaling factor for absorption coefficient look-up table
REAL(EB) :: KAPPA_C_FAC,LOG_KAPPA_C_FAC !< Scaling factor for soot coefficient look-up table
REAL(EB), ALLOCATABLE, DIMENSION(:,:) :: Y2RADCAL_SPECIES !< Primitive species mapping to radcal species
REAL(EB), ALLOCATABLE, DIMENSION(:,:,:,:) :: RADCAL_SPECIES2KAPPA ! Absorption coefficient look-up table
REAL(EB), ALLOCATABLE, DIMENSION(:) :: KAPPA_COND !< Array to remove condensed species from absorption coefficient look-up
INTEGER :: N_RADCAL_ARRAY_SIZE !< Number of radcal species present
INTEGER :: RADCAL_SPECIES_INDEX(16) !< Mapping of radcal species present to radcal calling function
CHARACTER(LABEL_LENGTH) :: RADCAL_SPECIES_ID(16)='NULL'!< Name of radcal species
Expand Down Expand Up @@ -3208,8 +3209,15 @@ SUBROUTINE INIT_RADIATION
CALL ChkMemErr('RADI','Y2RADCAL_SPECIES',IZERO)
Y2RADCAL_SPECIES = 0._EB

ALLOCATE(KAPPA_COND(N_TRACKED_SPECIES),STAT=IZERO)
CALL ChkMemErr('RADI','KAPPA_COND',IZERO)
KAPPA_COND = 1._EB

DO NS=1,N_TRACKED_SPECIES
IF( SPECIES_MIXTURE(NS)%EVAPORATION_SMIX_INDEX>0) CALL MEAN_CROSS_SECTIONS(SMIX_INDEX=NS)
IF (SPECIES_MIXTURE(NS)%EVAPORATION_SMIX_INDEX>0) THEN
CALL MEAN_CROSS_SECTIONS(SMIX_INDEX=NS)
KAPPA_COND(NS) = 0._EB
ENDIF
ENDDO
DO NS=1,N_SPECIES
SS => SPECIES(NS)
Expand Down Expand Up @@ -4675,11 +4683,14 @@ REAL(EB) FUNCTION GET_KAPPA(Z_IN,TMP,IBND)
! Returns the radiative absorption

USE PHYSICAL_FUNCTIONS, ONLY : GET_MOLECULAR_WEIGHT,GET_MASS_FRACTION_ALL
REAL(EB), INTENT(IN) :: Z_IN(1:N_TRACKED_SPECIES),TMP
REAL(EB), INTENT(INOUT) :: Z_IN(1:N_TRACKED_SPECIES)
REAL(EB), INTENT(IN) :: TMP
REAL(EB) :: KAPPA_TEMP,INT_FAC,KAPPA_SUM,SCALED_X_RADCAL_SPECIES,MWA,Y_OUT(1:N_SPECIES)
INTEGER, INTENT(IN) :: IBND
INTEGER :: LBND,UBND,N,TYY

Z_IN = Z_IN * KAPPA_COND

KAPPA_SUM = 0._EB

TYY = MAX(0 , MIN(N_KAPPA_T,INT((TMP - RTMPMIN) * TYY_FAC)))
Expand Down
4 changes: 2 additions & 2 deletions Verification/Miscellaneous/init_overlap.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Time,T20,D1p19,D1p51,P0p0,I6p0,T200,D0p938,I15p6,T427,D0p50,I9p9,T700,D0p42,I81p6,P0p5,P0p3
0.00E+00,2.00E+01,1.19E+00,1.51E+00,0.00E+00,6.00E+00,2.00E+02,9.38E-01,1.56E+01,4.28E+02,5.00E-01,9.90E+00,7.00E+02,4.18E-01,8.16E+01,5.00E-01,3.00E-01
1.00E-01,2.00E+01,1.19E+00,1.51E+00,0.00E+00,6.00E+00,2.00E+02,9.38E-01,1.56E+01,4.28E+02,5.00E-01,9.90E+00,7.00E+02,4.18E-01,8.16E+01,5.00E-01,3.00E-01
0.00E+00,2.00E+01,1.19E+00,1.51E+00,0.00E+00,5.85E+00,2.00E+02,9.38E-01,1.59E+01,4.28E+02,5.00E-01,9.80E+00,7.00E+02,4.18E-01,8.62E+01,5.00E-01,3.00E-01
1.00E-01,2.00E+01,1.19E+00,1.51E+00,0.00E+00,5.85E+00,2.00E+02,9.38E-01,1.59E+01,4.28E+02,5.00E-01,9.80E+00,7.00E+02,4.18E-01,8.62E+01,5.00E-01,3.00E-01
Loading