fix: End-to-end Docker overhaul — from broken setup to production-ready in one command#406
Open
utkarshqz wants to merge 10 commits intofireform-core:mainfrom
Open
fix: End-to-end Docker overhaul — from broken setup to production-ready in one command#406utkarshqz wants to merge 10 commits intofireform-core:mainfrom
utkarshqz wants to merge 10 commits intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FireForm can now be deployed end-to-end with a single command.
Before this PR, the Docker setup was broken in 10 different ways simultaneously — missing system libraries, wrong Python path, no port mapping, a server that never started, and an AI model that was never pulled. Every new contributor hit the same wall. Every station administrator who tried to self-host got the same crash.
This PR tears it all down and rebuilds it right.
After this PR, any contributor or station administrator — on any OS, with no prior setup — can do this:
And get a fully running, AI-powered, offline-capable FireForm instance at
http://localhost:8000— with the Mistral model, full API, Swagger docs, and PWA mobile client all live and working.No manual library installation. No PATH debugging. No silent failures.
What Was Broken (Root Cause Analysis)
DockerfilelibGL.so.1+libgthread-2.0.so.0— required by faster-whisperlibgl1,libglib2.0-0Dockerfilelibxcb.so.1missing frompython:3.11-slimbase imagelibxcb1Dockerfileffmpegmissing — required by faster-whisper audio processingffmpegDockerfile+docker-compose.ymlPYTHONPATH=/app/srcbroke every singleapi.*importPYTHONPATH=/appdocker-compose.ymlports:— the API server was completely unreachable from the hostports: ["8000:8000"]Makefilemake fireformnever pulled Mistral — all LLM calls failed silently at runtimepull-modeltofireformtargetMakefilemake testpointed tosrc/test/which does not existtests/DockerfileCMD ["tail", "-f", "/dev/null"]— container ran but FastAPI never starteduvicorn api.main:app --host 0.0.0.0 --port 8000docker-compose.ymlollama ps— not available in the Ollama image, caused instant failurerestart: unless-stoppedrequirements.txtpython-multipartmissing — FastAPI crashes at startup without itpython-multipartWhat FireForm Runs Now (After This PR)
http://localhost:8000http://localhost:8000/docshttp://localhost:8000/mobilehttp://localhost:11434(internal)Fully offline after first model pull. Zero cloud dependency. CJIS/GDPR-safe by design.
Fixes #275
Fixes #191
Fixes #184
Fixes #53
Fixes #224
Fixes #118
Fixes #116
Fixes #382
Type of change
How Has This Been Tested?
Full end-to-end deployment tested on Windows 11 + WSL2 + Docker Desktop 29.3.1 (CPU only, no NVIDIA GPU).
Test Configuration:
python:3.11-slimScreenshots
Build —
docker compose buildDeployment —
docker compose up -d+docker psAPI Live —
http://localhost:8000/docsFiles Changed
Dockerfiledocker-compose.ymlMakefilefireformtarget auto-pulls model, test path fixed,make runaddedrequirements.txtpython-multipartdocs/DEPLOYMENT.mdChecklist
docs/DEPLOYMENT.mdadded)