fix: point make test to tests/ instead of src/test/#381
Open
abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
Open
fix: point make test to tests/ instead of src/test/#381abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
Conversation
redbbean
added a commit
to redbbean/FireForm
that referenced
this pull request
Mar 31, 2026
implemented checkpointing/resuming pipeline: - hash transcript + field names to avoid collisions from different transcripts - atomic checkpoint writes to .tmp, then replacing previous checkpoint file - handling for Ctrl+C using SIGINT - retry loop for Ollama timeouts - JSONL error logging for Ollama -1 responses added docs required by issue fireform-core#131/fireform-core#133 have NOT added testing for the checkpointing yet added import error resolution from issue fireform-core#116/fireform-core#117 and fireform-core#118/fireform-core#119 added updated Makefile test path from issue fireform-core#380/fireform-core#381 haven't completely closed fireform-core#131/fireform-core#133 yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changed the
make testtarget in the Makefile fromsrc/test/totests/.Why
make testwas runningpytest src/test/, which only containstest_model.py— a manual smoke test script with no assertions. The actual test suite (conftest.py,test_forms.py,test_templates.py) lives in the roottests/directory and was being silently skipped.Changes
Testing
tests/contains the real pytest suite with fixtures and API test casessrc/test/test_model.pyhas no pytest assertions (just print + try/except)Fixes #380