Optimize fill_form by removing redundant get_template calls

[Lochit-Vinay]

This PR addresses inefficiency in the fill_form endpoint by removing redundant database calls.
Solves Issue #374

Summary

Optimized the fill_form endpoint by removing redundant calls to get_template().

Problem

The current implementation calls get_template() twice:

• Once to check if the template exists
• Again to fetch the template data

if not get_template(db, form.template_id):
    raise AppError("Template not found", status_code=404)

fetched_template = get_template(db, form.template_id)

This results in unnecessary database queries and reduced efficiency.

Solution

Refactored the code to call get_template() only once and reuse the result:

fetched_template = get_template(db, form.template_id)

if not fetched_template:
    raise AppError("Template not found", status_code=404)

Benefits

• Eliminates redundant database calls
• Improves performance
• Enhances code readability and maintainability

Additional Notes

This optimization reduces database load and improves endpoint efficiency, especially under repeated usage.
This change does not alter functionality but improves the efficiency of the endpoint by avoiding duplicate queries.

I’d be happy to extend this optimization to similar patterns across the codebase if needed.