Skip to content

Alternate link to Cloud Console#10283

Open
inlined wants to merge 3 commits intomainfrom
inlined.cloud-console-link
Open

Alternate link to Cloud Console#10283
inlined wants to merge 3 commits intomainfrom
inlined.cloud-console-link

Conversation

@inlined
Copy link
Copy Markdown
Member

@inlined inlined commented Apr 8, 2026

Alternate to #10235

@inlined inlined requested a review from kevmoo April 8, 2026 00:10
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a notification during the function release process to inform users that Dart functions might not yet be visible in the Firebase Console, providing a link to the Cloud Console instead. The review feedback suggests using the isLanguageRuntime utility instead of runtimeIsLanguage to avoid the use of non-null assertions on the runtime property, which aligns with the project's style guide regarding strict null checks.

printTriggerUrls(wantBackend, projectNumber);

// TODO: Remove once the Firebase console has support.
if (backend.someEndpoint(wantBackend, (endpoint) => runtimeIsLanguage(endpoint.runtime!, "dart"))) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use isLanguageRuntime to safely check the runtime. This avoids the use of the non-null assertion operator (!), which can lead to runtime errors if runtime is undefined. This change adheres to the repository's best practices for explicit null handling.

Suggested change
if (backend.someEndpoint(wantBackend, (endpoint) => runtimeIsLanguage(endpoint.runtime!, "dart"))) {
if (backend.someEndpoint(wantBackend, (endpoint) => isLanguageRuntime(endpoint.runtime, "dart"))) {
References
  1. Use strict null checks and handle undefined/null explicitly. Avoid using non-null assertions as escape hatches. (link)

Copy link
Copy Markdown
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the code well, but the message is right on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants