Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Fixed an issue where functions deployments would silently fail (#6989)
- Updates the default region for new App Hosting backends to us-east4 (#10271)
8 changes: 4 additions & 4 deletions src/apphosting/backend.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ describe("apphosting setup functions", () => {

describe("promptLocation", () => {
const supportedLocations = [
{ name: "us-central1", locationId: "us-central1" },
{ name: "us-east4", locationId: "us-east4" },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider retaining us-central1 in the mock data while adding us-east4. This ensures the test continues to verify the selection logic in a more realistic scenario where multiple common regions are available.

References
  1. Test error cases and edge conditions, not just the 'happy path'. (link)

{ name: "us-west1", locationId: "us-west1" },
];

Expand All @@ -358,16 +358,16 @@ describe("apphosting setup functions", () => {

it("returns a location selection", async () => {
const location = await promptLocation(projectId, /* prompt= */ "");
expect(location).to.be.eq("us-central1");
expect(location).to.be.eq("us-east4");
});

it("uses a default location prompt if none is provided", async () => {
await promptLocation(projectId);

expect(promptStub.select).to.be.calledWith({
default: "us-central1",
default: "us-east4",
message: "Please select a location:",
choices: ["us-central1", "us-west1"],
choices: ["us-east4", "us-west1"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the expected choices to include us-central1 to match the suggested change in the mock data.

References
  1. Test error cases and edge conditions, not just the 'happy path'. (link)

});
});

Expand Down
2 changes: 1 addition & 1 deletion src/apphosting/constants.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export const DEFAULT_LOCATION = "us-central1";
export const DEFAULT_LOCATION = "us-east4";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change modifies the default location for App Hosting, which is a user-facing change. Please ensure you have updated CHANGELOG.md as required by the repository style guide (Rule 58). Additionally, the pull request description should follow the required structure (including ### Description, ### Scenarios Tested, and ### Sample Commands) as specified in Rule 53.

References
  1. For any user-facing change (new features, bug fixes, deprecations), add a corresponding entry to CHANGELOG.md. (link)
  2. Structure commit messages and PR descriptions to include specific sections like ### Description, ### Scenarios Tested, and ### Sample Commands. (link)

export const DEFAULT_DEPLOY_METHOD = "github";
export const ALLOWED_DEPLOY_METHODS = [{ name: "Deploy using github", value: "github" }];
Loading