-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Change the default App Hosting region to us-east4 #10271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| - Fixed an issue where functions deployments would silently fail (#6989) | ||
| - Updates the default region for new App Hosting backends to us-east4 (#10271) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -347,7 +347,7 @@ describe("apphosting setup functions", () => { | |
|
|
||
| describe("promptLocation", () => { | ||
| const supportedLocations = [ | ||
| { name: "us-central1", locationId: "us-central1" }, | ||
| { name: "us-east4", locationId: "us-east4" }, | ||
| { name: "us-west1", locationId: "us-west1" }, | ||
| ]; | ||
|
|
||
|
|
@@ -358,16 +358,16 @@ describe("apphosting setup functions", () => { | |
|
|
||
| it("returns a location selection", async () => { | ||
| const location = await promptLocation(projectId, /* prompt= */ ""); | ||
| expect(location).to.be.eq("us-central1"); | ||
| expect(location).to.be.eq("us-east4"); | ||
| }); | ||
|
|
||
| it("uses a default location prompt if none is provided", async () => { | ||
| await promptLocation(projectId); | ||
|
|
||
| expect(promptStub.select).to.be.calledWith({ | ||
| default: "us-central1", | ||
| default: "us-east4", | ||
| message: "Please select a location:", | ||
| choices: ["us-central1", "us-west1"], | ||
| choices: ["us-east4", "us-west1"], | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update the expected choices to include References
|
||
| }); | ||
| }); | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| export const DEFAULT_LOCATION = "us-central1"; | ||
| export const DEFAULT_LOCATION = "us-east4"; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change modifies the default location for App Hosting, which is a user-facing change. Please ensure you have updated |
||
| export const DEFAULT_DEPLOY_METHOD = "github"; | ||
| export const ALLOWED_DEPLOY_METHODS = [{ name: "Deploy using github", value: "github" }]; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider retaining
us-central1in the mock data while addingus-east4. This ensures the test continues to verify the selection logic in a more realistic scenario where multiple common regions are available.References