Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ext:info command to include the source download URL in its output and enhances the listExtensions function to return extension parameters and system parameters. It also introduces a ListedExtension interface to provide better typing for the list results. Feedback was provided to move the ListedExtension interface to a centralized types file to improve maintainability and reusability.
| export interface ListedExtension { | ||
| extension: string; | ||
| publisher: string; | ||
| instanceId: string; | ||
| state: string; | ||
| version?: string; | ||
| updateTime: string; | ||
| params: Record<string, string>; | ||
| systemParams: Record<string, string>; | ||
| } |
There was a problem hiding this comment.
While defining the ListedExtension interface here is functional, it would be better for maintainability to move it to src/extensions/types.ts alongside other extension-related types. This keeps the codebase organized and makes the interface easily reusable by other commands or utilities that might need to process the output of listExtensions.
inlined
requested review from
shettyvarun268
and removed request for
shettyvarun268
2 participants
To facilitate forking extensions into a functions codebase we've added two additional features: