Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the firebase-security-rules-auditor skill, which provides a framework for evaluating Firebase Security Rules against a specific checklist and scoring system. Feedback suggests refining the admin privilege guidelines to ensure data integrity validation is still required even for administrative actions. Additionally, it is recommended to define a specific JSON schema for the output to improve programmatic parsing and consistency.
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
Seems like good to me - definitely ought to get some good human evals before we shi ptho
|
When you merge, can you also send a cl to update https://firebase.google.com/docs/ai-assistance/agent-skills#available-skills to list this skill too? |
Co-authored-by: Joe Hanley <joehanley@google.com>
Co-authored-by: Joe Hanley <joehanley@google.com>
2 participants
No description provided.