Syncing next and main by joehan · Pull Request #62 · firebase/agent-skills

joehan · 2026-04-02T16:41:52Z

No description provided.

* Add firebase-data-connect-basics skill (#7) * Add firebase-data-connect-basics skill * Add firebase dataconnect basic skills --------- Co-authored-by: Muhammad Talha <muhammadtalhar@google.com> * [Dataconnect] Restructure SKILL.md into a development workflow guide --------- Co-authored-by: Muhammad Talha <muhammadtalhar@google.com> Co-authored-by: Muhammad Talha <126821605+mtr002@users.noreply.github.com>

* Add Cursor plugin configuration * Add logo to cursor plugin config * Move logo to assets directory * Restructure Cursor plugin to multi-plugin format * Clean up language * Use a symlink instead

…#19)

Change all `firebase` shell command mentioned in the skills to use `npx -y firebase-tools@latest` instead to ensure freshness and reduce frictions to the agents.

- Move all one-time-only local environment setup from `firebase-basic` to `firebase-local-env-setup` skill - Add description about how to install skills and MCP server.

Based on https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-inputs

Co-authored-by: ssbushi <66321939+ssbushi@users.noreply.github.com>

* Add agent skills for firestore enterprise with native mode * Amend SKILL.md * Format SKILL * Address comments and rename standard edition * Remove files & update frontmatter * Updated to use "npx firebase-tools@latest" --------- Co-authored-by: Sichen Liu <sichenliu@google.com> Co-authored-by: Joe Hanley <joehanley@google.com>

Updated the installation reference guides for all supported agents (Antigravity, Claude Code, Cursor, Gemini CLI, GitHub Copilot, and others) in the `firebase-local-env-setup` skill. - Added detailed steps to locate, verify, and safely merge MCP configurations (`mcp.json`, `claude_desktop_config.json`, etc.) without overwriting existing entries. - Added explicit instructions to check for existing skill installations using `npx skills list` before installing. - Enforced "stop and wait" instructions for user restarts to ensure the agent correctly verifies the MCP server connection securely.

* Update `firebase-basics` skills - Optimize description so that it is more likely to be loaded - Clearly state the prerequisites, how to validate them and how to meet them. - Add principles about how to optimize agent ability to help with Firebase related task - Indexing other knowledges for progressive disclosure. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

) - Update their description so that firebase-basics can be picked up more consistently - Update instructions about how to refresh skills for Antigravity and other agents.

* docs: improve local installation instructions * docs: address reviewer feedback on local installation instructions

@gemini-code-assist

#52) * adjusting cursor plugin to reflect skills and mcp setup path correctly * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * update mcp path to ensure it can find it * correct the path --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Moving battlehardened AI studio prompt into skills * PR fixes * Address PR feedback: add isRecent, isAdmin, fix regex escaping and numbering * PR fixes * PR fixes

gemini-code-assist

Code Review

This pull request expands the repository with new agent skills for Genkit and Firebase Data Connect, automation scripts, and integration files for Cursor and Kiro. The review identified several issues, including incorrect yq flags in shell scripts, a command injection vulnerability in the token counter utility, and factual errors regarding Gemini model availability. Additionally, typos and broken links were found in the documentation.

gemini-code-assist · 2026-04-02T16:44:25Z

.github/scripts/prune-skills.sh

+  if [ -f "$skill_md" ]; then
+    # We use yq to check the metadata. 
+    # The '|| echo false' handles cases where the field is missing or yq fails.
+    is_managed=$(yq -f extract '.metadata["genkit-managed"] == true' "$skill_md" 2>/dev/null || echo false)


The yq command uses the -f flag with extract, which instructs yq to read the filter expression from a file named extract. This file is not present in the repository. If you intended to pass the filter string directly, the -f extract part should be removed.

Suggested change

is_managed=$(yq -f extract '.metadata["genkit-managed"] == true' "$skill_md" 2>/dev/null || echo false)

is_managed=$(yq '.metadata["genkit-managed"] == true' "$skill_md" 2>/dev/null || echo false)

gemini-code-assist · 2026-04-02T16:44:25Z

.github/scripts/sync-skills.sh

+
+  # Mark as managed by Genkit using yq
+  # The -i flag edits in place, -f process runs the filter
+  yq -i -f process '.metadata["genkit-managed"] = true' "$dest_dir/SKILL.md"


Similar to the prune script, the -f process flag instructs yq to look for a file named process containing the filter, which is missing. To apply the filter string directly, remove these flags.

Suggested change

yq -i -f process '.metadata["genkit-managed"] = true' "$dest_dir/SKILL.md"

yq -i '.metadata["genkit-managed"] = true' "$dest_dir/SKILL.md"

gemini-code-assist · 2026-04-02T16:44:26Z

scripts/skill-token-counter/index.js

+  process.exit(1);
+}
+
+const modelName = "gemini-3.1-pro-preview";


The model name gemini-3.1-pro-preview does not correspond to any currently available Google Generative AI model (current versions are 1.5 and 2.0). This will cause the script to fail when attempting to initialize the model.

Suggested change

const modelName = "gemini-3.1-pro-preview";

const modelName = "gemini-1.5-flash";

gemini-code-assist · 2026-04-02T16:44:26Z

scripts/skill-token-counter/index.js

+
+  getFileContent(ref, relativePath) {
+    try {
+      return execSync(`git show ${ref}:"${relativePath}"`, { stdio: 'pipe', cwd: this.root }).toString('utf8');


Using execSync with template literals containing variables like ref and relativePath is vulnerable to command injection if these variables contain shell metacharacters. It is safer to use execFileSync or spawnSync which allow passing arguments as an array, bypassing the shell.

gemini-code-assist · 2026-04-02T16:44:26Z

skills/developing-genkit-dart/references/genkit_mcp.md

+  ai.defineTool(
+    name: 'add',
+    description: 'Add two numbers together',
+    inputSchema: .map(.string(), .dynamicSChema()),


Typo in function name: .dynamicSChema() should be .dynamicSchema().

Suggested change

inputSchema: .map(.string(), .dynamicSChema()),

inputSchema: .map(.string(), .dynamicSchema()),

gemini-code-assist · 2026-04-02T16:44:26Z

skills/developing-genkit-js/references/best-practices.md

+
+## Model Selection (Google AI)
+-   **Gemini Models**: If using Google AI, ALWAYS use the latest generation (`gemini-3-*` or `gemini-2.5-*`).
+    -   **NEVER** use `gemini-2.0-*` or `gemini-1.5-*` series, as they are decommissioned and won't work.


The statement that Gemini 1.5 and 2.0 series are 'decommissioned and won't work' is factually incorrect. Gemini 1.5 is the current stable production series, and 2.0 is the latest generation. This documentation will mislead users and should be corrected to reflect actual model availability.

gemini-code-assist · 2026-04-02T16:44:26Z

skills/firebase-basics/SKILL.md

+   - **Gemini CLI**: Follow [references/refresh-gemini-cli.md](references/refresh-gemini-cli.md)
+   - **Claude Code**: Follow [references/refresh-claude.md](references/refresh-claude.md)
+   - **Cursor**: Follow [references/refresh-cursor.md](references/refresh-cursor.md)
+   - **Others**: Follow [references/refresh-other.md](references/refresh-other-agents.md)


The link text references/refresh-other.md is inconsistent with the actual filename references/refresh-other-agents.md provided in the repository.

Suggested change

- **Others**: Follow [references/refresh-other.md](references/refresh-other-agents.md)

- **Others**: Follow [references/refresh-other-agents.md](references/refresh-other-agents.md)

joehan and others added 30 commits February 11, 2026 14:57

Explanding out contributor guidelines (#3)

fce063e

update claude plugin marketplace command to use the new repo (#2)

62cf00e

add kiro power (#4)

60ef4b7

update license (#8)

771cef2

Adding a token counting script (#11)

88c0f8e

Adding a Cursor plugin (#13)

11db8e9

* Add Cursor plugin configuration * Add logo to cursor plugin config * Move logo to assets directory * Restructure Cursor plugin to multi-plugin format * Clean up language * Use a symlink instead

Add theme to GCLI extension (#17)

2720ebc

Remove curl|bash (#18)

c66a8c0

Update SKILL.md to remove references to 2.5 and instead use latest. (…

77cd16a

…#19)

feat: Add sync job for genkit-ai/skills (#23)

e67411e

Change to use npx to invoke Firebase CLI (#26)

16b47b6

Change all `firebase` shell command mentioned in the skills to use `npx -y firebase-tools@latest` instead to ensure freshness and reduce frictions to the agents.

use pat for cla reasons (#29)

b5085bf

fix: update workflow title and committer details (#33)

1287aca

Move the local environment setup to a new skill + MCP setup (#31)

06797c1

- Move all one-time-only local environment setup from `firebase-basic` to `firebase-local-env-setup` skill - Add description about how to install skills and MCP server.

fix: Add reviewers to sync-genkit-skills workflow (#35)

87575fe

Based on https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-inputs

chore: sync updated skills (#34)

c33c1db

Co-authored-by: ssbushi <66321939+ssbushi@users.noreply.github.com>

Update skill names in security rules documentation (#37)

7a30158

update the skill verification instruction (#38)

720d3ba

chore: sync updated skills (#39)

c4fcaab

gemini-3-pro-preview --> gemini-3.1-pro-preview (#40)

afbce83

Update firebase-basics skill and firebase-local-env-setup skill (#43

3f55d5a

) - Update their description so that firebase-basics can be picked up more consistently - Update instructions about how to refresh skills for Antigravity and other agents.

Split out python sdk content (#45)

861027a

Fixing up Cursor plugin format (#46)

da81537

docs: Improve local installation instructions (#47)

fcf78b8

* docs: improve local installation instructions * docs: address reviewer feedback on local installation instructions

Add new skills logo (#51)

83ee3be

charlotteliang and others added 4 commits March 26, 2026 19:06

re-organize claude plugins (#54)

893a3f2

Moving battlehardened AI studio prompt into skills (#53)

bec78e7

* Moving battlehardened AI studio prompt into skills * PR fixes * Address PR feedback: add isRecent, isAdmin, fix regex escaping and numbering * PR fixes * PR fixes

Merge firebase-local-env-setup skills into firebase-basics (#56)

0643b13

Change all firebase CLI reference to use npx firebase-tools (#61)

babd65e

gemini-code-assist bot reviewed Apr 2, 2026

View reviewed changes

joehan closed this Apr 2, 2026

ssbushi temporarily deployed to genkit skills automerger cron April 3, 2026 14:13 — with GitHub Actions Inactive

ssbushi temporarily deployed to genkit skills automerger cron April 6, 2026 14:18 — with GitHub Actions Inactive

ssbushi temporarily deployed to genkit skills automerger cron April 7, 2026 14:30 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Syncing next and main#62

Syncing next and main#62
joehan wants to merge 34 commits intonextfrom
main

joehan commented Apr 2, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Apr 2, 2026

Uh oh!

gemini-code-assist bot Apr 2, 2026

Uh oh!

gemini-code-assist bot Apr 2, 2026

Uh oh!

gemini-code-assist bot Apr 2, 2026

Uh oh!

gemini-code-assist bot Apr 2, 2026

Uh oh!

gemini-code-assist bot Apr 2, 2026

Uh oh!

gemini-code-assist bot Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

	is_managed=$(yq -f extract '.metadata["genkit-managed"] == true' "$skill_md" 2>/dev/null \|\| echo false)
	is_managed=$(yq '.metadata["genkit-managed"] == true' "$skill_md" 2>/dev/null \|\| echo false)

	yq -i -f process '.metadata["genkit-managed"] = true' "$dest_dir/SKILL.md"
	yq -i '.metadata["genkit-managed"] = true' "$dest_dir/SKILL.md"

	const modelName = "gemini-3.1-pro-preview";
	const modelName = "gemini-1.5-flash";

	inputSchema: .map(.string(), .dynamicSChema()),
	inputSchema: .map(.string(), .dynamicSchema()),

	- Others: Follow [references/refresh-other.md](references/refresh-other-agents.md)
	- Others: Follow [references/refresh-other-agents.md](references/refresh-other-agents.md)

Conversation

joehan commented Apr 2, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants