add firebase-functions-basics by jhuleatt · Pull Request #15 · firebase/agent-skills

jhuleatt · 2026-02-20T16:06:49Z

Add skills for Cloud Functions for Firebase

Fixes #9

skills/firebase-cloud-functions/SKILL.md

inlined · 2026-02-24T00:59:05Z

I have an entirely different skill on migrating from configs to params. Maybe we should not even mention config except as instructions to always use params instead? Can you ping me tomorrow about this?

jhuleatt · 2026-02-24T18:37:08Z

I have an entirely different skill on migrating from configs to params. Maybe we should not even mention config except as instructions to always use params instead? Can you ping me tomorrow about this?

@inlined, in the interest of getting this out in the hands of developers, want to either (1) keep upgrade.md for now, and then overwrite it with your own PR or update it to reference a new separate skill, or (2) delete upgrade.md and merge the rest of the skill?

skills/firebase-functions-basics/SKILL.md

skills/firebase-cloud-functions/SKILL.md

jhuleatt · 2026-02-25T21:11:30Z

@inlined I've removed upgrade.md and all references to functions.config, and renamed the skill to firebase-functions-basic. LGTY?

egilmorez

Some thoughts for you Jeff, thanks!

skills/firebase-functions-basics/references/node_setup.md

skills/firebase-functions-basics/SKILL.md

skills/firebase-functions-basics/references/node_setup.md

inlined

Should we teach the model that --functions is used when only emulating functions? A lot of functions depend on event sources and I almost never run only --functions.

We might also want to add the genkit UI in the npx concurrently call

skills/firebase-functions-basics/references/node_setup.md

skills/firebase-functions-basics/SKILL.md

lahirumaramba

Thank you, Jeff! Admin SDK sections LGTM!

jhuleatt · 2026-03-18T15:10:56Z

/gemini review

gemini-code-assist

Code Review

This pull request adds a new skill for Cloud Functions for Firebase, including guides for Node.js and Python. The documentation is a good start, but there are several critical and high-severity issues in the provided code examples and setup instructions. The Node.js example incorrectly mixes v1 and v2 function APIs, which will not work. The Python example has a bug in how it sets runtime options and also contains confusing, unused code. Additionally, some of the general guidance on SDK versions and import paths is inaccurate. I've provided suggestions to correct these issues to ensure the guides are accurate and functional.

gemini-code-assist · 2026-03-18T15:12:44Z

skills/firebase-functions-basics/references/node_setup.md

+import { setGlobalOptions, onInit } from "firebase-functions";
+import { onRequest } from "firebase-functions/https";
+import { onDocumentCreated } from "firebase-functions/firestore";
+import * as logger from "firebase-functions/logger";
+import { defineString, defineInt } from "firebase-functions/params";
+
+import { initializeApp } from "firebase-admin/app";
+
+// Configurable parameters
+const scaleLimit = defineInt("MAX_INSTANCES", { default: 1 });
+const greeting = defineString("GREETING", { default: "Hello" });
+
+onInit(() => {
+  initializeApp();
+  setGlobalOptions({ maxInstances: scaleLimit });
+});
+
+export const helloWorld = onRequest(async (request, response) => {
+  logger.info("Request received!", request);
+  response.send(`${greeting.value()} from Firebase!`);
+});
+
+export const newDoc = onDocumentCreated(
+  "/words/{wordId}",
+  async (event) => {
+    logger.info("New word!", event.data?.data());
+  }
+);


The provided code snippet for a 2nd-gen function is incorrect as it mixes APIs from both v1 and v2 of Cloud Functions, which will lead to errors. Specifically:

Imports for onRequest and onDocumentCreated should be from firebase-functions/v2/... subpaths for 2nd-gen functions.

The onInit lifecycle hook is for v1 functions and should not be used.

setGlobalOptions should be imported from firebase-functions/v2 and called at the top level.

Logging the entire request object can be a security risk and produce noisy logs. It's better to log specific, non-sensitive properties.

Here is a corrected version of the snippet that properly implements 2nd-gen functions:

import { onRequest } from "firebase-functions/v2/https"; import { onDocumentCreated } from "firebase-functions/v2/firestore"; import * as logger from "firebase-functions/logger"; import { defineString, defineInt } from "firebase-functions/params"; import { initializeApp } from "firebase-admin/app"; import { setGlobalOptions } from "firebase-functions/v2"; initializeApp(); // Configurable parameters const scaleLimit = defineInt("MAX_INSTANCES", { default: 1 }); const greeting = defineString("GREETING", { default: "Hello" }); setGlobalOptions({ maxInstances: scaleLimit }); export const helloWorld = onRequest(async (request, response) => { logger.info("Request received!", { body: request.body }); response.send(`${greeting.value()} from Firebase!`); }); export const newDoc = onDocumentCreated( "/words/{wordId}", async (event) => { logger.info("New word!", event.data?.data()); } );

What is your source for that information? The default import has been 2nd gen for a while now, so I want to correct the source you're using.

skills/firebase-functions-basics/SKILL.md

gemini-code-assist · 2026-03-18T15:12:44Z

skills/firebase-functions-basics/references/python_setup.md

+admin_app = None
+
+@init
+def initialize():
+  options.set_global_options(max_instances=SCALE_LIMIT)
+
+  global admin_app
+  admin_app = initialize_app()


There are a couple of issues in the initialize function:

The admin_app global variable is assigned but never used, which is confusing. Calling initialize_app() is sufficient as it sets up the default app instance.

The SCALE_LIMIT parameter is an IntParam object. To use its integer value for max_instances, you must call the .value() method. Passing the object directly will cause a runtime error.

Suggested change

admin_app = None

@init

def initialize():

options.set_global_options(max_instances=SCALE_LIMIT)

global admin_app

admin_app = initialize_app()

@init

def initialize():

options.set_global_options(max_instances=SCALE_LIMIT.value())

initialize_app()

skills/firebase-functions-basics/SKILL.md

gemini-code-assist · 2026-03-18T15:12:44Z

skills/firebase-functions-basics/references/python_setup.md

+  admin_app = initialize_app()
+
+@https_fn.on_request(
+    cors=options.CorsOptions(cors_origins="*", cors_methods=["get", "post"])


Using a wildcard * for cors_origins allows any origin to access your function, which can be a security risk. For production environments, it is strongly recommended to restrict this to a specific list of allowed domains. For a guide, it's better to show a more secure example or add a note about this.

Suggested change

cors=options.CorsOptions(cors_origins="*", cors_methods=["get", "post"])

cors=options.CorsOptions(cors_origins=["https://your-web-app.com"], cors_methods=["get", "post"])

joehan

Some nits, but this looks very good to me!

joehan · 2026-03-03T19:00:03Z

skills/firebase-functions-basics/references/node_setup.md

+);
+```
+
+**Key points for the agent:**


Suggested change

**Key points for the agent:**

**Key points:**

Its all for the agent

joehan · 2026-03-03T19:00:10Z

skills/firebase-functions-basics/references/node_setup.md

+);
+```
+
+**Key points for the agent:**


Suggested change

**Key points for the agent:**

**Key points:**

Its all for the agent

skills/firebase-functions-basics/SKILL.md

add a CF3 skill

496ed2b

lahirumaramba reviewed Feb 23, 2026

View reviewed changes

skills/firebase-cloud-functions/SKILL.md Outdated Show resolved Hide resolved

jhuleatt added 2 commits February 24, 2026 13:33

use modular Admin SDK import

f65ab01

change upgrade instructions to use new defineJsonSecret flow

0075f47

jhuleatt added 2 commits February 24, 2026 16:25

rename to cloud-functions-basics

628dd86

rename to firebase-functions-basics

5b0dab9

joehan reviewed Feb 25, 2026

View reviewed changes

skills/firebase-functions-basics/SKILL.md Outdated Show resolved Hide resolved

skills/firebase-cloud-functions/SKILL.md Outdated Show resolved Hide resolved

remove upgrade guide and all references to functions.config

addcf4c

jhuleatt requested review from egilmorez, joehan and lahirumaramba February 26, 2026 14:46

jhuleatt changed the title ~~Add Cloud Functions for Firebase~~ add firebase-functions-basics Feb 26, 2026

egilmorez reviewed Feb 26, 2026

View reviewed changes

inlined reviewed Feb 28, 2026

View reviewed changes

lahirumaramba approved these changes Mar 2, 2026

View reviewed changes

jhuleatt added 7 commits March 10, 2026 10:37

address review feedback

17b5f7e

add a note about the --only functions flag

6a4b256

address review feedback

1d7ea8b

initialize admin app in language-specific examples

99c9f0d

remove --only flag from emulator commands

094ea0b

add null check to TS example code

dac9f75

mention emulators:exec in main guide

4981b84

gemini-code-assist bot reviewed Mar 18, 2026

View reviewed changes

joehan approved these changes Mar 24, 2026

View reviewed changes

	cors=options.CorsOptions(cors_origins="*", cors_methods=["get", "post"])
	cors=options.CorsOptions(cors_origins=["https://your-web-app.com"], cors_methods=["get", "post"])

Conversation

jhuleatt commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

inlined commented Feb 24, 2026

Uh oh!

jhuleatt commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

jhuleatt commented Feb 25, 2026

Uh oh!

egilmorez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inlined left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lahirumaramba left a comment

Choose a reason for hiding this comment

Uh oh!

jhuleatt commented Mar 18, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

jhuleatt Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

joehan left a comment

Choose a reason for hiding this comment

Uh oh!

joehan Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

joehan Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jhuleatt commented Feb 20, 2026 •

edited

Loading