Fix #184: Rebuild dist/ with correct TypeScript generic parameters#191
Open
erikras-richard-agent wants to merge 1 commit intomasterfrom
Open
Fix #184: Rebuild dist/ with correct TypeScript generic parameters#191erikras-richard-agent wants to merge 1 commit intomasterfrom
erikras-richard-agent wants to merge 1 commit intomasterfrom
Conversation
…types
v4.0.0 was published with outdated dist/index.d.ts that was missing the
generic parameter in UseFieldArrayConfig. The source file (src/index.d.ts)
is correct, but dist/ needs to be rebuilt before publishing.
This version bump will trigger a new build and publish with the correct types:
export interface UseFieldArrayConfig<FieldValue>
extends UseFieldConfig<FieldValue[]> { // <-- Generic was missing in v4.0.0
📝 WalkthroughWalkthroughVersion number incremented from 4.0.0 to 4.0.1 in package.json as a patch release. No functional code changes are included in this update. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
erikras
reviewed
Feb 10, 2026
| { | ||
| "name": "react-final-form-arrays", | ||
| "version": "4.0.0", | ||
| "version": "4.0.1", |
Member
There was a problem hiding this comment.
Why would bumping the version fix anything related to the types?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #184 - TypeScript error:
Property 'map' does not exist on type 'FieldValue'Root Cause
The
dist/index.d.tsfile was missing the generic parameter<FieldValue[]>in theUseFieldArrayConfiginterface definition (line 4). The source filesrc/index.d.tswas correct, butdist/hadn't been rebuilt after the v4.0.0 TypeScript conversion.Solution
Rebuilt the package using
yarn start buildto regeneratedist/index.d.tsfrom the correct source. Bumped version to 4.0.1 to republish with corrected types.Changes
dist/index.d.tswith proper generic parameter:package.jsonto4.0.1Testing
dist/index.d.tsnow matchessrc/index.d.tsgeneric structureRelated
Part of OSS-21 (🟠 HIGH: Fix v4.0.0 regressions)
Summary by CodeRabbit