Use form.getState() directly instead of using subscriptions.#16
Open
BowlingX wants to merge 1 commit intofinal-form:masterfrom
Open
Use form.getState() directly instead of using subscriptions.#16BowlingX wants to merge 1 commit intofinal-form:masterfrom
form.getState() directly instead of using subscriptions.#16BowlingX wants to merge 1 commit intofinal-form:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 44 40 -4
Branches 11 11
=====================================
- Hits 44 40 -4
Continue to review full report at Codecov.
|
Author
|
Any more information required to have this merged? :) |
|
I like how this simplifies things. Any reason we shouldn't merge this, @erikras? |
|
@erikras Could you please give some feedback on this issue. We're having the same problem in our projects and have to use fork of this library with similar patch applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :),
I was running into timing issues on async error handling (with final-form
4.18.6and react-final-form6.3.3). (The promise inonSubmitwould resolve before / at the same time the subscription callback fires and would compare against a stale state. I'm not sure why the subscription is needed because we have access to the form state directly withgetState().This pull request adresses the issue of a potential stale state.