Closed
Conversation
eb8f3be to
bf905f4
Compare
4e9acae to
7a41938
Compare
7a41938 to
af7b124
Compare
nsaini-figma
approved these changes
Mar 9, 2026
Proxy LFS batch API requests to upstream GitHub with auth, enabling clients to use Goblet for LFS without needing direct GitHub credentials. Also update Go and runtime base images.
af7b124 to
8d7b265
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pass-through proxy for Git LFS batch API requests. LFS requests (
POST /info/lfs/objects/batch) are detected before the Git protocol v2 check, authenticated viaRequestAuthorizer, and forwarded upstream with the server's OAuth2 token. The response (containing download URLs) is streamed back to the client.This is a pass-through proxy — no LFS object caching. Per the Basic Transfer API spec, download URLs are returned in the batch response's
actions.download.hreffield, which for GitHub points to external cloud storage. Clients fetch objects directly from those URLs, bypassing Goblet.LFS endpoints
Read paths (relevant for Goblet):
POST /info/lfs/objects/batch— Batch API for discovering download/upload URLs (currently supported)GET /info/lfs/objects/:oid— Direct object download via "basic" transfer. Some servers support this as a fallback, but GitHub uses the batch API exclusively and returns signed S3 URLs in the batch response, so this is unlikely to be hit.Write paths (not relevant — Goblet is read-only):
POST /info/lfs/objects— Legacy single-object upload (deprecated)POST /info/lfs/locks— Create a lockPOST /info/lfs/locks/verify— List locks for pre-push verificationPOST /info/lfs/locks/:id/unlock— Delete a lockUnsupported
/info/lfs/paths return HTTP 501.Spec references: Batch API, Basic Transfers, File Locking
Notes to Reviewers
LFS routing intentionally sits between
RequestAuthorizerand theGit-Protocol: version=2check, since LFS uses its own HTTP/JSON protocol rather than Git wire protocol.Test Plan
I manually validated it by doing the following:
Then with that checked out locally:
Then watch this succeed in another terminal: