Merged
Conversation
Contributor
luisrodero-fidesmo
left a comment
luisrodero-fidesmo
left a comment
There was a problem hiding this comment.
Quite good! I've just posted one comment and one question, please check.
| import java.net.MalformedURLException; | ||
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
| import java.net.URL; |
Contributor
There was a problem hiding this comment.
I think the import at line 36 is not needed now
Contributor
Author
There was a problem hiding this comment.
You are totally right, fixed!
| <groupId>com.fidesmo</groupId> | ||
| <artifactId>fdsm-toolbox</artifactId> | ||
| <version>25.02.15-SNAPSHOT</version> | ||
| <version>25.11.25-SNAPSHOT</version> |
Contributor
There was a problem hiding this comment.
Question: where did you get this new version number from?
Contributor
Author
There was a problem hiding this comment.
I followed the steps in the readme, and I made make release, which did that changes to the versions. But I think there were/are some problems with releasing and versioning so maybe I should put 02.15 again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task
As mentioned in the task, it was needed to upgrade it to java 21.
Did some batching & unbatching, and also install & uninstall of bob, with this new version locally and everything worked fine.