Switch KDL parsers (from kdl crate to kdlite)#362
Open
DorianNiemiecSVRJS wants to merge 4 commits intodevelop-2.xfrom
Open
Switch KDL parsers (from kdl crate to kdlite)#362DorianNiemiecSVRJS wants to merge 4 commits intodevelop-2.xfrom
kdl crate to kdlite)#362DorianNiemiecSVRJS wants to merge 4 commits intodevelop-2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request would replace
kdlcrate withkdlitecrate. It also removes themiettecrate dependency.The
kdlitecrate is a small, streaming KDL parser for Rust, which is based onjust-kdlcrate.Motivation
From
kdliteRust crate documentation:Performance tests
Setup
Ferron is started with the KDL-format configuration generated using this script (that can be run on Node.js):
This script can be then run like this (on GNU/Linux):
Ferron with
kdlcrate:Ferron with
kdlitecrate:Comparsion
Ferron with
kdlitecrate took only 1.351s for processing the server configuration, while Ferron withkdlcrate took 3.461s for processing the same configuration.