Skip to content

Add Icon field to Goal model and unit tests for GetForUser#150

Open
Ezaj24 wants to merge 1 commit intofencer-so:mainfrom
Ezaj24:feature/add-icon-support
Open

Add Icon field to Goal model and unit tests for GetForUser#150
Ezaj24 wants to merge 1 commit intofencer-so:mainfrom
Ezaj24:feature/add-icon-support

Conversation

@Ezaj24
Copy link
Copy Markdown

@Ezaj24 Ezaj24 commented Mar 29, 2026

Changes Made

Backend (Task 1)

  • Added optional Icon field to Goal model (Goal.cs)

Testing (Task 4)

  • Completed GetForUser unit test in GoalControllerTests.cs
  • All 11 tests passing

Purpose

This PR adds icon support to the Goal model and ensures
test coverage for the GetForUser controller route.

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 29, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 893b201 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant