Windows sdl

[fbraz3]

• Copilot revision
• Manual builds - all OS
• Manual run tests - all OS
  • MacOS
  • Linux
  • Windows

[Copilot]

Pull request overview

Copilot reviewed 41 out of 549 changed files in this pull request and generated 5 comments.

[Copilot]

Same issue as D3DX11: this looks like a self-include of the umbrella header (d3dx10.h). It’s redundant under include guards and makes include graphs harder to reason about. Remove it and keep only the intended subordinate includes.

Suggested change

#include "d3dx10.h"

[Copilot]

Providing an empty token can cause dorny/paths-filter to lose access to PR file lists (rate limits / missing permissions) and behave inconsistently. Prefer omitting the input (so it defaults) or set it explicitly to ${{ github.token }}.

Suggested change

	token: ${{ github.token }}

[Copilot]

These summary expressions don’t treat the skipped job result as a skip, so if should-build is false the build jobs will be skipped and the summary will incorrectly show ❌ Failed. Update the condition to consider skipped (and/or cancelled) as a non-failure status in the table output.

Suggested change

	echo "| Linux (x86_64) | ${{ needs.build-linux.result == 'success' && '✅ Success' || (needs.build-linux.result == 'cancelled' || needs.build-linux.result == 'skipped') && '⏭️ Skipped' || '❌ Failed' }} |" >> $GITHUB_STEP_SUMMARY
	echo "| macOS (arm64) | ${{ needs.build-macos.result == 'success' && '✅ Success' || (needs.build-macos.result == 'cancelled' || needs.build-macos.result == 'skipped') && '⏭️ Skipped' || '❌ Failed' }} |" >> $GITHUB_STEP_SUMMARY
	echo "| Windows (x64/modern) | ${{ needs.build-windows.result == 'success' && '✅ Success' || (needs.build-windows.result == 'cancelled' || needs.build-windows.result == 'skipped') && '⏭️ Skipped' || '❌ Failed' }} |" >> $GITHUB_STEP_SUMMARY

[Copilot]

When vcpkg is restored from cache, the workflow skips the git checkout pin entirely, so the cached vcpkg revision can drift from the intended commit. Consider always validating/pinning the vcpkg commit (even when cached), e.g., fetch + checkout the desired SHA, to keep builds reproducible.

Suggested change

	if (-not (Test-Path "C:\vcpkg\vcpkg.exe")) {
	Write-Host "Cloning vcpkg from GitHub..."
	git clone https://github.com/microsoft/vcpkg.git C:\vcpkg
	git -C C:\vcpkg checkout ffc071e0c08432c60c9b64f00334c0227667931b
	Write-Host "Running vcpkg bootstrap..."
	& C:\vcpkg\bootstrap-vcpkg.bat -disableMetrics
	} else {
	Write-Host "Using cached vcpkg"
	# Ensure vcpkg repository exists (clone if missing)
	if (-not (Test-Path "C:\vcpkg\.git")) {
	Write-Host "Cloning vcpkg from GitHub..."
	git clone https://github.com/microsoft/vcpkg.git C:\vcpkg
	} else {
	Write-Host "Using existing vcpkg checkout (possibly from cache)"
	}
	# Ensure vcpkg is at the expected pinned commit for reproducible builds
	Write-Host "Ensuring vcpkg is at the expected commit..."
	git -C C:\vcpkg fetch origin --tags --prune
	git -C C:\vcpkg checkout --force ffc071e0c08432c60c9b64f00334c0227667931b
	# Bootstrap only if the vcpkg executable is not present
	if (-not (Test-Path "C:\vcpkg\vcpkg.exe")) {
	Write-Host "Running vcpkg bootstrap..."
	& C:\vcpkg\bootstrap-vcpkg.bat -disableMetrics
	} else {
	Write-Host "vcpkg executable already present; skipping bootstrap"

[Copilot]

Same reproducibility issue as the Windows workflow: if /opt/vcpkg is reused from cache, the pinned checkout won’t be applied and the vcpkg revision may differ from the intended SHA. Apply the checkout (or at least verify HEAD) even when vcpkg already exists.