Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Display lured pokemon#184

Open
szeco wants to merge 3 commits intofavll:masterfrom
szeco:master
Open

Display lured pokemon#184
szeco wants to merge 3 commits intofavll:masterfrom
szeco:master

Conversation

@szeco
Copy link
Copy Markdown

@szeco szeco commented Aug 10, 2016

Additional block in updateMap to display lured pokemon. Uses pokestops checkbox to control visibility.

szeco added 3 commits August 10, 2016 10:32
Renames the 'display pokestops' checkbox to control whether to display lured pokemon on the map
@stlmikey80
Copy link
Copy Markdown

stlmikey80 commented Aug 10, 2016

so this will show pokemon from lured pokestops?

tried to add this, i must of messed up somewhere.. I took away all my pokemon showing.. couldnt view any...

@szeco
Copy link
Copy Markdown
Author

szeco commented Aug 10, 2016

can you see any errors in the js console log?

@TheUrbanNinja
Copy link
Copy Markdown

Seems to work for me.

@djv2
Copy link
Copy Markdown

djv2 commented Aug 14, 2016

just tried this, doesn't work

@drsnooker
Copy link
Copy Markdown

Works here, keep in mind, lured pokemon only exist for 2 minutes or so then pop back out of existence.

@djv2
Copy link
Copy Markdown

djv2 commented Aug 15, 2016

@drsnooker i've scanned multiple locations with 20+ going on at once, i get nothing from this script

@drsnooker
Copy link
Copy Markdown

drsnooker commented Aug 15, 2016

@djv2 not sure how to help. Took me awhile to get it working. Something to do with pasting from the raw window... Just hit files changed, view, and raw than save as from your browser. That got it working first (but using an older version of the map.html and map.js (just to see how it works) put a 100 m circle on a lured pokestop and enable all pokemon. Some will show "Lured XXXXXX" with less then 2 minutes remaining.

The newer version of the map.html and map.js have moved things around so make sure you copy the lines from the mod over to the correct location (not what's labelled in this file)
Oh and verify that you've selected "show lured pokemon" check box in the setup

@herculys
Copy link
Copy Markdown

you must add a new button, you cant replace display pokestops with display lured pokemons, cause i need display pokestops button.

@adamblaine
Copy link
Copy Markdown

Thank you for this, @szeco! I combined your changes with those from #317 this morning in an attempt to get notifications about lured pokemon. At first I wasn't sure it was working -- I didn't see any lured pokemon show up after checking the box. But an hour or so later they started showing up! Awesome.

I hit a snag, though -- the IDs for the lured pokemon appear to be different so while I'm notified that a "Dratini" is near, I receive no notification for a "luredDratini", though it does show up on my map. Do you know what the proper IDs would be for lured pokemon? If Bulbasaur is "1", luredBulbasaur should be..?

Also, would it be possible to get the "View Lured Pokemon" checkbox to remember the choice? When I load up my map I have to ensure it's checked every time, unlike "View Gyms" and "View Pokemon."

@adamblaine
Copy link
Copy Markdown

Also just to follow up-- it appears that lured Pokemon show up on my map on my android phone, but not on my desktop pc, even after ensuring that the "show lured Pokemon" option is enabled.

Might explain why some people aren't able to see it working. I didn't believe it worked until I checked from my phone. What would cause this issue for the desktop map?

@szeco
Copy link
Copy Markdown
Author

szeco commented Aug 18, 2016

Hi @adamblaine - it's a bit more complicated to merge with #317 as it's a model.py based notification rather than a map.js one. Since lured pokemon data is stored in the pokestops item you could probably replicate the entire pushbullet code block around line 205 using active_pokemon_id.

Another method I've had success with is moving the entire notification piece into map.js by using this: https://github.com/alexschneider/pushbullet-js

Unfortunately I'm not using pogom as my main map any more since most of my smurfs have been banned :( only have one account now running PokemonGo-Map with spawnpoint scanning in a small area..

@adamblaine
Copy link
Copy Markdown

Ah okay. I tried messing around with it but couldn't get anything that would work. I don't have any working knowledge of python or js so I'm just stumbling through trying to get this to work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants