Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Added GMaps search box to top-right corner#146

Open
ensingm2 wants to merge 3 commits intofavll:masterfrom
ensingm2:searchBar
Open

Added GMaps search box to top-right corner#146
ensingm2 wants to merge 3 commits intofavll:masterfrom
ensingm2:searchBar

Conversation

@ensingm2
Copy link
Copy Markdown
Contributor

@ensingm2 ensingm2 commented Aug 9, 2016

Not sure if this one should be added or not. It's super useful, but requires 'Google Places API Web Service' to be enabled in the user's Google API (Not having this enabled doesn't BREAK anything else, but it doesn't remove the nonfunctional search box either, and the console will yell at you if you try to search).

You may need to edit the README and tell users to add the extra Lib for this one.

@ghost
Copy link
Copy Markdown

ghost commented Aug 9, 2016

@ensingm2 How does this show up on Mobile?

@ensingm2
Copy link
Copy Markdown
Contributor Author

ensingm2 commented Aug 9, 2016

@Lionir Looks fine to me (tested in chrome-beta, firefox on android), I'm running on a 1440p phone through so someone may want to test it on a more standard res. Give me a sec and I'll put up some screens.

EDIT: Screens. Autocomplete overlaps menu button while typing, but I don't think that's an issue.
searchbar1
searchbar2

@ghost
Copy link
Copy Markdown

ghost commented Aug 10, 2016

@ensingm2 I think it'd be better if you could make it part of the sidebar, don't you think? (Maybe at the top of the sidebar) Now that I think about it, what if it could also act to find Pokemons currently on the map? (I know I might be asking much but I think that'd be an awesome feature)

@MasterGameZ
Copy link
Copy Markdown

How did you add this?

@ensingm2
Copy link
Copy Markdown
Contributor Author

@MasterGameZ: I pretty much just used the relevant code from the Google example at: https://developers.google.com/maps/documentation/javascript/examples/places-searchbox

@MasterGameZ
Copy link
Copy Markdown

MasterGameZ commented Aug 11, 2016

Can you send me the replaced files please?

@ensingm2
Copy link
Copy Markdown
Contributor Author

You can find the files by clicking on the commits at the top of this PR and then pressing 'view' (though they aren't up to date with current master). Keep in mind you need to add the Google Places API Web Service to your API key as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants