types!: migrate static decorators to registration-scoped typing#565
Open
types!: migrate static decorators to registration-scoped typing#565
Conversation
Member
|
Do the inline type tags also need updating as part of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
@fastify/statictyping from globalFastifyReplydeclarationaugmentation to registration-scoped decorator inference.
Changes include:
types/index.d.tsnow models reply decorators as plugin-applied effects;types/index.test-d.tsrewritten to assert decorator availability only onregistered instances;
behavior.
Dependency
This PR is part of the declaration-merging removal stack and depends on:
feat/typed-decorators)Please review/merge with that core change in mind.
Validation
npm run test:typescript✅npm run lint -- types✅Context
Refs fastify/fastify#5061.