types: replace declaration merging with mixin types#427
Draft
flakey5 wants to merge 1 commit intofastify:mainfrom
Draft
types: replace declaration merging with mixin types#427flakey5 wants to merge 1 commit intofastify:mainfrom
flakey5 wants to merge 1 commit intofastify:mainfrom
Conversation
841c06a to
9a73cde
Compare
climba03003
reviewed
Sep 2, 2024
Member
There was a problem hiding this comment.
I believe if we going to be this approach, we should provides two types file.
- The plugin types with mixin.
- The declaration merging types named
fastify-global.d.ts.
It allows the users to choice which approach fit there application.
The second option can be consumed using the tsconfig.json by the following way.
{
"compilerOptions": {
"types": ["@fastify/static/fastify-global"]
}
}
4 tasks
This only works for top level projects. I would much prefer it to be handled through an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Fastify v5, background: fastify/fastify#5061
Opened this as it is now to get early feedback & insight. Used a class rather than an interface or type since the type needs to exist at runtime if we go with the currently proposed changes to the
fastify-pluginapi (see fastify/fastify#5061 (comment))TODO:
cc @mcollina
Checklist
npm run testandnpm run benchmarkand the Code of conduct