Conversation
gurgunday
left a comment
gurgunday
left a comment
There was a problem hiding this comment.
I think mysql is fine? @jean-michelet WDYT?
|
It is fine, but often people use postgres so I am ok with the switch. |
Signed-off-by: Luca Raveri <lucaraveri993@gmail.com>
|
| "knex": "^3.1.0", | ||
| "mysql2": "^3.15.0", | ||
| "pg": "^8.16.3", | ||
| "pg-query-stream": "^4.10.3", |
There was a problem hiding this comment.
I hit this bug in CI while running the test “Task image upload, retrieval and delete”:
Cannot find module 'pg-query-stream'
Run: https://github.com/fastify/demo/actions/runs/20621476554/job/59224136187
Adding the dependency fixes the error. What’s odd is that the tests pass locally without it.
Any idea why CI behaves differently here and how can I fix it?
There was a problem hiding this comment.
I think this is required by knex.
There was a problem hiding this comment.
Yess, it's required by knex as mentioned here.
|
Not the best person to review postgre PR, @kibertoad maybe? |
3 participants
Summary
As mentioned in issue #74, I believe it makes sense to migrate this project to PostgreSQL.
Postgres is far more commonly adopted in modern TypeScript ecosystems and is often the default choice for new projects.
Test Plan