feat: SIMD compilation mode - CPU portable vs native mode selection#67
Merged
nyurik merged 5 commits intofast-pack:mainfrom Mar 5, 2026
Merged
feat: SIMD compilation mode - CPU portable vs native mode selection#67nyurik merged 5 commits intofast-pack:mainfrom
nyurik merged 5 commits intofast-pack:mainfrom
Conversation
7933656 to
f6ec63c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a configurable SIMD compilation mode for the FastPFOR C++ backend (portable vs native vs runtime), improving build/CI flexibility and clarifying usage for consumers.
Changes:
- Adds SIMD mode selection via Cargo features and
FASTPFOR_SIMD_MODE, wiring the selection throughbuild.rsinto CMake. - Updates dev workflows (
justfile) and CI matrix to exercise multiple SIMD modes. - Updates docs and bumps crate version to
0.8.0.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
justfile |
Standardizes dev commands on _all_compatible and adds SIMD-mode test recipes. |
build.rs |
Detects SIMD mode via features/env var and forwards it to CMake with warnings. |
README.md |
Documents SIMD modes and configuration knobs for end users. |
Cargo.toml |
Adds SIMD-related features and bumps crate version. |
.github/workflows/ci.yml |
Expands CI matrix to test multiple SIMD modes and separates caches per mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CommanderStorm
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new SIMD mode configuration system for the FastPFOR crate, allowing users to select between portable, native, and runtime SIMD instruction sets for the C++ backend. The changes improve build flexibility, CI reliability, and documentation clarity, while updating the crate version and standardizing feature usage in development scripts.
SIMD Mode Configuration and Build System
portable,native, orruntime) via Cargo features and theFASTPFOR_SIMD_MODEenvironment variable; the build script now warns if multiple SIMD features are enabled and passes the selected mode to CMake. (build.rs,Cargo.toml) [1] [2].github/workflows/ci.yml)Documentation Improvements
README.mdwith a clear explanation of SIMD modes, their use cases, and configuration recommendations for end users.Development Scripts and Testing
_all_compatiblefeature group in thejustfilefor building, testing, linting, and coverage, and added recipes to test all SIMD modes. [1] [2] [3] [4]justfilefor development tools, with clearer output and better CI compatibility.Version Update
0.7.0to0.8.0to reflect these breaking and feature enhancements. (Cargo.toml)