fix async for usage with python 3.7#134
fix async for usage with python 3.7#134douglasrizzo wants to merge 3 commits intofacebookresearch:masterfrom
Conversation
in python37, async is a reserved word, so I changed it
|
Hi douglasrizzo! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
OK, my fix didn't work when using the GPU. I took a look at the documentation for the |
|
I had a problem on my side by pushing from my master branch. I created a new PR #135 from a new branch now |
In Python 3.7,
asyncis a reserved word, so I changed it (there were only a few occurrences) toasynch. This has only affected.pyfiles.