Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Update elf to support pytorch 0.4#109

Open
alcinos wants to merge 5 commits intofacebookresearch:mainfrom
alcinos:update_elf
Open

Update elf to support pytorch 0.4#109
alcinos wants to merge 5 commits intofacebookresearch:mainfrom
alcinos:update_elf

Conversation

@alcinos
Copy link
Copy Markdown

@alcinos alcinos commented Jul 3, 2018

This PR updates the code base to be somewhat compatible with the new version of Pytorch.
Note that the new Pytorch version includes fixes in important things like the multinomial distribution (which is used in ELF). Hence it can lead to a different behaviour.

A summary of the changes:

  • Use .item() where appropriate. I may have missed some places, since I only tested this PR on Atari
  • Remove volatile and use torch.no_grad instead
  • Some stricter reshaping to cope with finickier dimension checks

Unfortunately, merging this PR means that ELF no longer works on 0.3 and earlier.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants