Force CLIP text encoder onto CUDA if availabe to avoid CPU NaN outputs in Jetson Xavier#125
Open
mqcmd196 wants to merge 1 commit intofacebookresearch:mainfrom
Open
Force CLIP text encoder onto CUDA if availabe to avoid CPU NaN outputs in Jetson Xavier#125mqcmd196 wants to merge 1 commit intofacebookresearch:mainfrom
mqcmd196 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
…ailabe to avoid CPU NaN outputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc: @HiroIshida
On Jetson Xavier (with CPU highload?),
prints
It seems that sometimes the CLIP embedding is broken with some reason (sometimes works...)
Using the Python script
I checked on my Jetson Xavier and x86/RTX3090Ti machine.
Jetson Xavier prints
The result means that it seems that the embeddings has been broken when it is on CPU in Xavier.
This PR explicitly places the encoder on cuda when available. I confirmed the patch make the function stable in Jetson Xavier. I think this patch doesn't break other features.