Fix docstring inconsistencies in multicalibration library (#258)#258
Closed
Fix docstring inconsistencies in multicalibration library (#258)#258
Conversation
TaXxER
requested review from
Lorenzo-Perini,
danielha1 and
flinder
as code owners
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 9 9
Lines 1917 1917
=======================================
Hits 1842 1842
Misses 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meta-codesync
bot
changed the title
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
Summary: - multi_cg_score: Fix param 'predictions' docstring from 'predicted labels' to 'predicted scores' to match parameter name; fix return type annotation from npt.NDArray to pd.Series to match actual return; fix return docstring accordingly - _rank_multicalibration_error: Fix return docstring from 'an array' to 'a Series' to match pd.Series return type annotation Reviewed By: flinder Differential Revision: D98851485
meta-codesync
bot
force-pushed
the
export-D98851485
branch
from
9cd888c to
1645fa2
Compare
Summary: Pull Request resolved: #258 - multi_cg_score: Fix param 'predictions' docstring from 'predicted labels' to 'predicted scores' to match parameter name; fix return type annotation from npt.NDArray to pd.Series to match actual return; fix return docstring accordingly - _rank_multicalibration_error: Fix return docstring from 'an array' to 'a Series' to match pd.Series return type annotation Reviewed By: flinder Differential Revision: D98851485
|
This pull request has been merged in 8712e86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
'predicted scores' to match parameter name; fix return type annotation from
npt.NDArray to pd.Series to match actual return; fix return docstring accordingly
to match pd.Series return type annotation
Reviewed By: flinder
Differential Revision: D98851485