[unplugin] Fix Vite 8 CSS duplication#1547
Open
skovhus wants to merge 2 commits intofacebook:mainfrom
Open
Conversation
In Vite 8 (Rolldown), CSS assets are present during generateBundle, causing StyleX CSS to be injected twice — once in generateBundle and again in writeBundle. Track whether generateBundle succeeded and skip writeBundle when it did, preserving the fallback for SSR/Workers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verify that writeBundle is skipped when generateBundle already injected CSS, and that the writeBundle fallback still works when no CSS asset exists during generateBundle (SSR/Workers). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
skovhus
requested review from
ezzak,
mellyeliu,
nmn and
vincentriemer
as code owners
|
@skovhus is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
In Vite 8 (Rolldown), CSS assets are present during
generateBundle, causing StyleX CSS to be injected twice — once ingenerateBundleand again inwriteBundle.This PR tracks whether
generateBundlesucceeded and skipwriteBundlewhen it did, preserving the fallback for SSR/Workers.Linked PR/Issues
n/a
Additional Context
n/a
Pre-flight checklist
Contribution Guidelines