Open
Conversation
It was removing stylex_compiled_modules during each call which is not expected since in case of multiple external modules, only the last one remains and previous one would be deleted while copying next one.
Refactor subscription logic with dedicated functions (registerSubscription, compileAndCleanup) and add module watching capabilities to track changes in external dependencies.
Export COMPILED_MODULES_DIR_NAME from modules.js and update references across the CLI codebase to ensure consistency in the directory name used for compiled modules.
devhd9
requested review from
ezzak,
mellyeliu,
necolas,
nmn and
vincentriemer
as code owners
|
@devhd9 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
The StyleX CLI had two issues related to
modules_EXPERIMENTALsupport:1. Bug in
fetchModulefetchModulewas callingfs.rmSyncon the entirestylex_compiled_modulesdirectory before copying each module.When multiple external modules were configured, this caused destructive overwrite behavior:
2. No watch mode support for external modules
The CLI’s
--watchmode only tracked changes inside the input source directory.Changes inside external modules (
modules_EXPERIMENTAL) were not detected, requiring a manual restart to re-fetch and recompile them.Linked PR/Issues
Fixes #731
Additional Context
Added tests in
compile-stylex-folder-test.jsto verify thatcopyNodeModulescorrectly preserves:No breaking changes — the fix and added functionality are additive and only affect
modules_EXPERIMENTALbehavior.Pre-flight checklist
Contribution Guidelines