Skip to content

Fix Hermes crash from TurboModule void method NSException handling #56265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabriziocucci wants to merge 1 commit into from
+3 −1
Closed

Fix Hermes crash from TurboModule void method NSException handling #56265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...act-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,9 @@ TraceSection s(
@try {
[inv invokeWithTarget:strongModule];
} @catch (NSException *exception) {
throw convertNSExceptionToJSError(runtime, exception, std::string{moduleName}, methodNameStr);
// Void methods are always async, re-throw instead of converting to
// JSError, same as the async branch in performMethodInvocation.
@throw exception;
} @finally {
[retainedObjectsForInvocation removeAllObjects];
}
Expand Down
Loading