Skip to content

Change all remaining flow legacy casting syntax to modern one #56259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamChou19815 wants to merge 1 commit into from
+1,289 −1,282
Closed

Change all remaining flow legacy casting syntax to modern one #56259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion packages/debugger-shell/src/electron/SettingsStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class SettingsStore {
const data = fs.readFileSync(this.path, 'utf8');
const deserializedData = this._deserialize(data);
return {
...((deserializedData: any): {[string]: unknown}),
...(deserializedData as any as {[string]: unknown}),
};
} catch (error) {
if (error?.code === 'ENOENT') {
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-middleware/src/__tests__/InspectorDeviceUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class DeviceMock extends DeviceAgent {
});
break;
default:
(message: empty);
message as empty;
throw new Error(`Unhandled event ${message.event}`);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-middleware/src/__tests__/InspectorProtocolUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export async function createAndConnectTarget(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down
22 changes: 11 additions & 11 deletions packages/dev-middleware/src/__tests__/InspectorProxyCdpTransport-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -121,7 +121,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -189,7 +189,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -306,7 +306,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -356,7 +356,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -431,7 +431,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -477,7 +477,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -515,7 +515,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -578,7 +578,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -632,7 +632,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down Expand Up @@ -689,7 +689,7 @@ describe.each(['HTTP', 'HTTPS'])(
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});
const [{webSocketDebuggerUrl}] = pageList;
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-middleware/src/__tests__/InspectorProxyConcurrentSessions-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('inspector proxy concurrent sessions', () => {
pageList = (await fetchJson(
`${serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toHaveLength(1);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/dev-middleware/src/__tests__/InspectorProxyCustomMessageHandler-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('inspector proxy device message middleware', () => {
pageList = (await fetchJson(
`${serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList.length).toBeGreaterThan(0);
});
invariant(pageList != null, '');
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-middleware/src/__tests__/InspectorProxyDeviceHandoff-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ describe('inspector-proxy device socket handoff', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toEqual(
expect.arrayContaining(
pageListSpec.map(pageSpec =>
Expand Down
14 changes: 7 additions & 7 deletions packages/dev-middleware/src/__tests__/InspectorProxyReactNativeReloads-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('inspector proxy React Native reloads', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList.length).toBeGreaterThan(0);
});
invariant(pageList != null, '');
Expand Down Expand Up @@ -114,7 +114,7 @@ describe('inspector proxy React Native reloads', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toContainEqual(
expect.objectContaining({
id: expect.stringContaining('originalPage-updated'),
Expand Down Expand Up @@ -171,7 +171,7 @@ describe('inspector proxy React Native reloads', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList.length).toBeGreaterThan(0);
});
invariant(pageList != null, '');
Expand Down Expand Up @@ -224,7 +224,7 @@ describe('inspector proxy React Native reloads', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toContainEqual(
expect.objectContaining({
id: expect.stringContaining('originalPage-updated'),
Expand Down Expand Up @@ -275,7 +275,7 @@ describe('inspector proxy React Native reloads', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList.length).toBeGreaterThan(0);
});
invariant(pageList != null, '');
Expand Down Expand Up @@ -429,7 +429,7 @@ describe('inspector proxy React Native reloads', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList.length).toBeGreaterThan(0);
});
invariant(pageList != null, '');
Expand Down Expand Up @@ -465,7 +465,7 @@ describe('inspector proxy React Native reloads', () => {
pageList = (await fetchJson(
`${serverRef.serverBaseUrl}/json`,
// $FlowFixMe[unclear-type]
): any);
)) as any;
expect(pageList).toContainEqual(
expect.objectContaining({
id: expect.stringContaining('originalPage-updated'),
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-middleware/src/createDevMiddleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ function createWrappedEventReporter(
);
break;
default:
(event.result.code: empty);
event.result.code as empty;
break;
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/dev-middleware/src/middleware/openDebuggerMiddleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export default function openDebuggerMiddleware({
shouldUseStandaloneFuseboxShell = false;
break;
default:
(shellPreparationResult.code: empty);
shellPreparationResult.code as empty;
}
}
if (shouldUseStandaloneFuseboxShell) {
Expand Down Expand Up @@ -226,7 +226,7 @@ export default function openDebuggerMiddleware({
res.end();
break;
default:
(launchType: empty);
launchType as empty;
}
eventReporter?.logEvent({
type: 'launch_debugger_frontend',
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-codegen/src/generators/components/ComponentsGeneratorUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function getNativeTypeFromAnnotation(
case 'MixedTypeAnnotation':
return 'folly::dynamic';
default:
(typeAnnotation: empty);
typeAnnotation as empty;
throw new Error(
`Received invalid typeAnnotation for ${componentName} prop ${prop.name}, received ${typeAnnotation.type}`,
);
Expand Down
8 changes: 4 additions & 4 deletions packages/react-native-codegen/src/generators/components/CppHelpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function getCppTypeForAnnotation(
case 'MixedTypeAnnotation':
return 'folly::dynamic';
default:
(type: empty);
(type) as empty;
throw new Error(`Received invalid typeAnnotation ${type}`);
}
}
Expand Down Expand Up @@ -95,7 +95,7 @@ function getCppArrayTypeForAnnotation(
// Unions of strings and string literals are treated as just strings
return `std::vector<${getCppTypeForAnnotation('StringTypeAnnotation')}>`;
default:
(validUnionType: empty);
validUnionType as empty;
throw new Error(`Unsupported union member type`);
}
case 'ObjectTypeAnnotation':
Expand Down Expand Up @@ -241,7 +241,7 @@ function convertDefaultTypeToString(
case 'DimensionPrimitive':
return '';
default:
(typeAnnotation.name: empty);
typeAnnotation.name as empty;
throw new Error(
`Unsupported type annotation: ${typeAnnotation.name}`,
);
Expand Down Expand Up @@ -283,7 +283,7 @@ function convertDefaultTypeToString(
case 'MixedTypeAnnotation':
return '';
default:
(typeAnnotation: empty);
typeAnnotation as empty;
throw new Error(`Unsupported type annotation: ${typeAnnotation.type}`);
}
}
Expand Down
16 changes: 8 additions & 8 deletions packages/react-native-codegen/src/generators/components/GenerateComponentHObjCpp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ function getObjCParamType(param: Param): string {
case 'RootTag':
return 'double';
default:
(typeAnnotation.name: empty);
typeAnnotation.name as empty;
throw new Error(`Receieved invalid type: ${typeAnnotation.name}`);
}
case 'BooleanTypeAnnotation':
Expand All @@ -174,7 +174,7 @@ function getObjCParamType(param: Param): string {
case 'ArrayTypeAnnotation':
return 'const NSArray *';
default:
(typeAnnotation.type: empty);
typeAnnotation.type as empty;
throw new Error('Received invalid param type annotation');
}
}
Expand All @@ -188,7 +188,7 @@ function getObjCExpectedKindParamType(param: Param): string {
case 'RootTag':
return '[NSNumber class]';
default:
(typeAnnotation.name: empty);
typeAnnotation.name as empty;
throw new Error(`Receieved invalid type: ${typeAnnotation.name}`);
}
case 'BooleanTypeAnnotation':
Expand All @@ -204,7 +204,7 @@ function getObjCExpectedKindParamType(param: Param): string {
case 'ArrayTypeAnnotation':
return '[NSArray class]';
default:
(typeAnnotation.type: empty);
typeAnnotation.type as empty;
throw new Error('Received invalid param type annotation');
}
}
Expand All @@ -218,7 +218,7 @@ function getReadableExpectedKindParamType(param: Param): string {
case 'RootTag':
return 'double';
default:
(typeAnnotation.name: empty);
typeAnnotation.name as empty;
throw new Error(`Receieved invalid type: ${typeAnnotation.name}`);
}
case 'BooleanTypeAnnotation':
Expand All @@ -234,7 +234,7 @@ function getReadableExpectedKindParamType(param: Param): string {
case 'ArrayTypeAnnotation':
return 'array';
default:
(typeAnnotation.type: empty);
typeAnnotation.type as empty;
throw new Error('Received invalid param type annotation');
}
}
Expand All @@ -251,7 +251,7 @@ function getObjCRightHandAssignmentParamType(
case 'RootTag':
return `[(NSNumber *)arg${index} doubleValue]`;
default:
(typeAnnotation.name: empty);
typeAnnotation.name as empty;
throw new Error(`Receieved invalid type: ${typeAnnotation.name}`);
}
case 'BooleanTypeAnnotation':
Expand All @@ -267,7 +267,7 @@ function getObjCRightHandAssignmentParamType(
case 'ArrayTypeAnnotation':
return `(NSArray *)arg${index}`;
default:
(typeAnnotation.type: empty);
typeAnnotation.type as empty;
throw new Error('Received invalid param type annotation');
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-codegen/src/generators/components/GenerateEventEmitterCpp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ function generateSetters(
usingEvent,
);
default:
(typeAnnotation.type: empty);
typeAnnotation.type as empty;
throw new Error(
`Received invalid event property type ${typeAnnotation.type}`,
);
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-codegen/src/generators/components/GenerateEventEmitterH.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function getNativeTypeFromAnnotation(
eventProperty.name,
]);
default:
(typeAnnotation.type: empty);
typeAnnotation.type as empty;
throw new Error(
`Received invalid event property type ${typeAnnotation.type}`,
);
Expand Down Expand Up @@ -274,7 +274,7 @@ function generateStruct(
);
return;
default:
(typeAnnotation.type: empty);
typeAnnotation.type as empty;
throw new Error(
`Received invalid event property type ${typeAnnotation.type}`,
);
Expand Down
Loading
Loading