Add cookbookrspec key and CookbookRspecExists rule#12
Closed
dafyddcrosby wants to merge 1 commit intofacebook:mainfrom
Closed
Add cookbookrspec key and CookbookRspecExists rule#12dafyddcrosby wants to merge 1 commit intofacebook:mainfrom
dafyddcrosby wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@dafyddcrosby has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90535240. |
Summary: Pull Request resolved: facebook#12 Add a new bookworm key `cookbookrspec` to detect RSpec test files in cookbooks, and create a corresponding `CookbookRspecExists` rule. Since normal rspec and chefspec can be side-by-side, I opted for the more generic key. We're ignoring helper-type files, only focusing on _spec since that's where the tests need to reside. The key uses: - glob_pattern: */spec/*_spec.rb - path_name_regex: spec/(.*)_spec\.rb - determine_cookbook_name: true This enables bookworm to track which cookbooks have RSpec test files. Differential Revision: D90535240
dafyddcrosby
force-pushed
the
export-D90535240
branch
from
fa7a8cb to
d741b33
Compare
meta-codesync bot
pushed a commit
to facebook/chef-cookbooks
that referenced
this pull request
Jan 14, 2026
Summary: X-link: facebook/bookworm#12 Add a new bookworm key `cookbookrspec` to detect RSpec test files in cookbooks, and create a corresponding `CookbookRspecExists` rule. Since normal rspec and chefspec can be side-by-side, I opted for the more generic key. We're ignoring helper-type files, only focusing on _spec since that's where the tests need to reside. The key uses: - glob_pattern: */spec/*_spec.rb - path_name_regex: spec/(.*)_spec\.rb - determine_cookbook_name: true This enables bookworm to track which cookbooks have RSpec test files. Reviewed By: joshuamiller01 Differential Revision: D90535240 fbshipit-source-id: 1d2f958ac61b5afd089bebc62f1435fef4390412
|
This pull request has been merged in df51490. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new bookworm key
cookbookrspecto detect RSpec test files incookbooks, and create a corresponding
CookbookRspecExistsrule. Since normalrspec and chefspec can be side-by-side, I opted for the more generic key. We're
ignoring helper-type files, only focusing on _spec since that's where the tests
need to reside.
The key uses:
This enables bookworm to track which cookbooks have RSpec test files.
Differential Revision: D90535240