Skip to content

Extend iOS xcrun xctrace profiling to handle other types#532

Open
KarlSimonsen wants to merge 1 commit intofacebook:mainfrom
KarlSimonsen:export-D40612255
Open

Extend iOS xcrun xctrace profiling to handle other types#532
KarlSimonsen wants to merge 1 commit intofacebook:mainfrom
KarlSimonsen:export-D40612255

Conversation

@KarlSimonsen
Copy link
Copy Markdown

Summary:
Add infrastructure to allow alternate templates for iOS Instruments Profiling. This should allow us to see how useful the other flavors of Instruments profiling can be, once we get the dSYM files generated in the build and deployment.

This diff covers Memory and GPU Instruments profiling, as well as the options to specify other templates using the advanced "options": { "template": "CPU Profiler" } syntax.

Reviewed By: axitkhurana

Differential Revision: D40612255

Summary:
Add infrastructure to allow alternate templates for iOS Instruments Profiling. This should allow us to see how useful the other flavors of Instruments profiling can be, once we get the dSYM files generated in the build and deployment.

This diff covers Memory and GPU Instruments profiling, as well as the options to specify other templates using the advanced "options": { "template": "CPU Profiler" } syntax.

Reviewed By: axitkhurana

Differential Revision: D40612255

fbshipit-source-id: dac8cf0bdf2ccff26167fcf6640f28b2570d99ee
@facebook-github-bot
Copy link
Copy Markdown

This pull request was exported from Phabricator. Differential Revision: D40612255

@facebook-github-bot
Copy link
Copy Markdown

Hi @KarlSimonsen!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants