Allow passing random extra args to simpleperf#514
Open
digantdesai wants to merge 1 commit intofacebook:mainfrom
Open
Allow passing random extra args to simpleperf#514digantdesai wants to merge 1 commit intofacebook:mainfrom
digantdesai wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: * Works only with Simpleperf (cpu) for now, silently ignored by other profilers * The `extra_args` field defaults to an empty string, and goes to the simpleperf cmdline like this, `simpleperf record -g -o <filemame> <extra_args> <app cmdline>` * No actual testing is done on the incoming string, it is passed to simple perf as is for now Reviewed By: axitkhurana Differential Revision: D37830096 fbshipit-source-id: faa841bc4720af08992c204fe7dd6caf466839fc
|
This pull request was exported from Phabricator. Differential Revision: D37830096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
extra_argsfield defaults to an empty string, and goes to the simpleperf cmdlinelike this,
simpleperf record -g -o <filemame> <extra_args> <app cmdline>Reviewed By: axitkhurana
Differential Revision: D37830096