Parse "all_heaps" option argument correctly for protoBuf format#501
Parse "all_heaps" option argument correctly for protoBuf format#501KarlSimonsen wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: Support Perfetto on unrooted devices The following tries to remove all dependencies on the device being rooted. How well it works on unrooted devices remains to be seen. Differential Revision: D35863747 fbshipit-source-id: 2914f7429508a1e89201fccecf02e9dd03ee8b61
Summary: Protobuf requires boolean arguments to be lowercase "true" or "false". Reviewed By: MarkAndersonIX Differential Revision: D36302473 fbshipit-source-id: 10ffa728a2bcac033ca34b9d1e7be52b93568822
|
This pull request was exported from Phabricator. Differential Revision: D36302473 |
|
Hi @KarlSimonsen! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
2 participants
Summary: Protobuf requires boolean arguments to be lowercase "true" or "false".
Reviewed By: MarkAndersonIX
Differential Revision: D36302473