Do not fail job if subprocess called with ignore_status argument#498
Do not fail job if subprocess called with ignore_status argument#498vmpuri wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Jobs should not be marked as failed if a subprocess has `kwargs["ignore_status"] == True` Or if "silent" is True Reviewed By: KarlSimonsen Differential Revision: D36103193 fbshipit-source-id: 873d4eda7e51430f85dda4a6c8656cd5b80f58d4
|
This pull request was exported from Phabricator. Differential Revision: D36103193 |
|
Hi @vmpuri! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
2 participants
Summary:
Jobs should not be marked as failed if a subprocess has
kwargs["ignore_status"] == TrueOr if "silent" is True
Reviewed By: KarlSimonsen
Differential Revision: D36103193