elfmalloc: Bubble up OOM errors, remove unnecessary internal code#160
Open
elfmalloc: Bubble up OOM errors, remove unnecessary internal code#160
Conversation
- Make many internal methods return Option<T> rather than T and return None on OOM - Remove CoarseAllocator::backing_memory and replace it with page_size (which was all the former method was ever being used for)
joshlf
force-pushed
the
elfmalloc-fallible-methods
branch
from
b35d69e to
ed36a35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option<T>rather thanTand returnNoneon OOMCoarseAllocator::backing_memoryand replace it withpage_size(which was all the former method was ever being used for)This PR is a subset of PR #159 because that PR is giving me issues, so I figured breaking it into smaller PRs would make it easier to debug.