Fix compile probe and nightly backtraces by ten3roberts · Pull Request #160 · eyre-rs/eyre

ten3roberts · 2024-03-26T12:19:31Z

This addresses the invalid compile probe testing for a non-longer existing feature by updating it and eyre to use the error_generic_member_access features instead.

The report and errors have all been updated to accomodate this and the new backtrace provide API

Fixes: #84 and #97

ten3roberts · 2024-03-26T12:27:55Z

I have to pin trybuild as it has added a dependency to toml which only supports >1.70

ten3roberts · 2024-03-26T12:42:13Z

Well... this is embarassing.

Once again the backtrace test is being finicky, this time due to (I believe) a warning injected by cargo, breaking it all.

ten3roberts · 2024-03-26T13:17:19Z

I fixed it in #161 and included the fix here.

Will rebase ontop of #161 when that is merged

RalfJung · 2024-03-26T17:22:55Z

eyre/build.rs

-        _ => {}
-    }
+    // Supports invoking rustc thrugh a wrapper
+    let mut cmd = if let Some(wrapper) = env::var_os("RUSTC_WRAPPER") {


It turns out there is also RUSTC_WORKSPACE_WRAPPER which should probably be honored as well. Furthermore, the wrapper can be empty and that means "no wrapping".

This is a reasonable template to start with.

thenorili · 2024-03-28T19:59:48Z

~~It looks like this isn't quite finished.~~ Have you considered working from this PR to fix nightly backtraces?

#124

eyre/tests/generic_member_access.rs

README.md

This addresses the invalid compile probe testing for a non-longer existing feature by updating it and eyre to use the `error_generic_member_access` features instead. The report and errors have all been updated to accomodate this and the new backtrace provide API Fixes: #84 and #97

thenorili

This looks okay to me to move forward with, sorry for the slowness!

thenorili · 2024-05-06T09:33:14Z

eyre/src/wrapper.rs

Not your code / out of scope: We're getting a couple dead code errors in this file with DisplayError and NoneError. I'm surprised they're triggered even though we marked them public. Why don't we tag these structs as #[allow(dead_code)]?

I am similarly distressed by the other warnings we get a dozen copies of down below. I thought the missing_doc_code_examples thing was resolved ages ago.

I'm surprised they're triggered even though we marked them public.

pub in a private module can still be dead code.

pub(crate) is not even public, though.

Yes, I understand that. I guess my surprise is that it's existing code that's had attention paid to its visibility and yet it's dead. I'll find the last time it wasn't dead code and figure its story out.

thenorili · 2024-05-06T09:49:20Z

eyre/build.rs

What was your motivation for rewriting this file?

thenorili · 2024-05-06T09:52:35Z

README.md

+
+Backtraces are captured when an error is converted to an `eyre::Report` (such as using `?` or `eyre!`).
+
+If using the nightly toolchain, backtraces will also be captured and accessed from other errors using [error_generic_member_access](https://github.com/rust-lang/rfcs/pull/2895) if available.


Per #121, some folks will continue to be unhappy about enforcing unstable features whenever we detect nightly. IIRC we discussed a while ago that we want to accomodate that use case. It doesn't make it any worse so I think it's fine to put that work off, but I thought it was worth mentioning.

Yeah, not wanting to break existing behavior in a "fix" PR, but rather make existing up to date nightly a tricky beast when it comes to libraries.

ten3roberts added the A-eyre Area: eyre subcrate label Mar 26, 2024

ten3roberts mentioned this pull request Mar 26, 2024

Backtrace is not available due to Error API change #97

Closed

ten3roberts force-pushed the fix-nightly-backtraces branch from bc5017d to 4881cd2 Compare March 26, 2024 12:21

ten3roberts mentioned this pull request Mar 26, 2024

Eyre broken in rust-analyzer with nightly #155

Closed

ten3roberts force-pushed the fix-nightly-backtraces branch from 4881cd2 to 011f9a1 Compare March 26, 2024 12:26

ten3roberts force-pushed the fix-nightly-backtraces branch from 011f9a1 to be497c8 Compare March 26, 2024 12:34

ten3roberts force-pushed the fix-nightly-backtraces branch from be497c8 to fdb7d84 Compare March 26, 2024 13:13

RalfJung reviewed Mar 26, 2024

View reviewed changes

ten3roberts commented Mar 28, 2024

View reviewed changes

eyre/tests/generic_member_access.rs Show resolved Hide resolved

ten3roberts commented Mar 28, 2024

View reviewed changes

eyre/tests/generic_member_access.rs Show resolved Hide resolved

LeoniePhiline reviewed Mar 31, 2024

View reviewed changes

README.md Show resolved Hide resolved

thenorili mentioned this pull request Apr 25, 2024

Update to the new backtrace API #124

Closed

thenorili self-assigned this Apr 25, 2024

thenorili self-requested a review April 25, 2024 21:12

thenorili assigned ten3roberts and unassigned thenorili Apr 25, 2024

ten3roberts added 2 commits April 25, 2024 23:27

fix: use RUST_WORKSPACE_WRAPPER in compile probe

92b6a57

ten3roberts force-pushed the fix-nightly-backtraces branch from e766676 to 92b6a57 Compare April 25, 2024 21:27

fix: remove duplicate thiserror reference

3d7b20d

thenorili approved these changes May 6, 2024

View reviewed changes

ten3roberts added 3 commits May 13, 2024 18:47

Merge branch 'master' into fix-nightly-backtraces

dacfb55

fix: empty doc comments disallowed by clippy

dd05aa3

Merge branch 'master' into fix-nightly-backtraces

87ee15e

ten3roberts merged commit df42dc4 into master Jul 18, 2024

ten3roberts deleted the fix-nightly-backtraces branch July 18, 2024 20:24

stusmall mentioned this pull request Jan 25, 2025

New release? #215

Closed


		Backtraces are captured when an error is converted to an `eyre::Report` (such as using `?` or `eyre!`).

		If using the nightly toolchain, backtraces will also be captured and accessed from other errors using [error_generic_member_access](https://github.com/rust-lang/rfcs/pull/2895) if available.

Conversation

ten3roberts commented Mar 26, 2024

Uh oh!

ten3roberts commented Mar 26, 2024

Uh oh!

ten3roberts commented Mar 26, 2024

Uh oh!

ten3roberts commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfJung Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thenorili commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thenorili left a comment

Choose a reason for hiding this comment

Uh oh!

thenorili May 6, 2024

Choose a reason for hiding this comment

Uh oh!

RalfJung May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thenorili May 6, 2024

Choose a reason for hiding this comment

Uh oh!

thenorili May 6, 2024

Choose a reason for hiding this comment

Uh oh!

thenorili May 6, 2024

Choose a reason for hiding this comment

Uh oh!

ten3roberts May 13, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ten3roberts commented Mar 26, 2024 •

edited

Loading

RalfJung Mar 26, 2024 •

edited

Loading

thenorili commented Mar 28, 2024 •

edited

Loading

RalfJung May 6, 2024 •

edited

Loading