Merged
Conversation
this will allow the overwhelming majority of parsing to be shared between Event and Todo
* ICal.Serialize gets a few more functions from Serialize.Event * ICal.Serialize.Component hosts two macros for serialization
control whether a param is added to a list based on the list-ness of the component field type
everything be `to_ics` was misleading and difficult to follow now components (events, todos, etc) serialize via `component` paramaters, via `paramater` Serialize now offers `value` In other words, each of the serializing functions do what they say they do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding VTODO and VJOURNAL.
This also centralizes parsing into
De/Serialize.Componentmodules which provide macros with shared implementations. As a result of this, VTODO and VJOURNAL were added in about half an hour each once the refactoring was done.This also moves away from the
to_icsandfrom_icsfunction naming everywhere, leaving it only for top-level calendars. Functions are now named after whether they are serializing or deserializing values, properties, and components.