feat: add direct Base L2 support for Basenames (*.base.eth)#20
Open
vickcharles wants to merge 3 commits intoethlimo:mainfrom
Open
feat: add direct Base L2 support for Basenames (*.base.eth)#20vickcharles wants to merge 3 commits intoethlimo:mainfrom
vickcharles wants to merge 3 commits intoethlimo:mainfrom
Conversation
This adds native support for resolving contenthash records from Basenames (*.base.eth) by querying the Base L2 resolver directly, bypassing the Coinbase CCIP gateway which doesn't return contenthash. Changes: - Add BasenamesService to query Base L2 resolver at 0xC6d566A56A1aFf6508b41f6c90ff131615583BCD - Add IConfigurationBase interface for Base RPC configuration - Update NameServiceFactory to route *.base.eth to BasenamesService - Add BASE_RPC_ENDPOINT environment variable (defaults to https://mainnet.base.org)
Member
|
Hi @vickcharles thank you for your submission. Our team will review this. Were any LLM tools used for this commit? Would you also please add the necessary test cases and specify the new environment variables in |
Add test cases for example.base.eth and norecord.base.eth, wire up testBasenamesService in the integration test harness, and document the BASE_RPC_ENDPOINT environment variable in README.
Author
Hi @eth-limo! Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
BasenamesServiceto query Base L2 resolver at0xC6d566A56A1aFf6508b41f6c90ff131615583BCDIConfigurationBaseinterface for Base RPC configurationNameServiceFactoryto route*.base.ethtoBasenamesServiceBASE_RPC_ENDPOINTenvironment variable (defaults tohttps://mainnet.base.org)Context
Coinbase's CCIP gateway at
api.coinbase.com/api/v1/domain/resolver/resolveDomaindoesn't return contenthash records for Basenames, preventing dwebsites from loading via eth.limo. This PR adds direct L2 resolution as a workaround.Test plan
vickler.base.eth- successfully resolves contenthash toipfs://bafybeifoze5lboyc7nxlqv2bfbd4irrxk3jj5qi7udsm2gklv3uq7qosde