Closed
Conversation
|
danthelion
reviewed
Mar 6, 2026
| * Package - ghcr.io/estuary/materialize-amazon-rds-sqlserver:v2 | ||
| * Apache Iceberg Tables | ||
| * [Configuration](./apache-iceberg.md) | ||
| * [Configuration](./Apache-Iceberg/Apache-Iceberg.md) |
Contributor
There was a problem hiding this comment.
Is there a reason to captialize these instead of sticking to all lowercase?
Collaborator
There was a problem hiding this comment.
+1
If we don't need to create a redirect for capitalization, it's usually better not to.
aeluce
reviewed
Mar 6, 2026
| * Package - ghcr.io/estuary/materialize-amazon-rds-sqlserver:v2 | ||
| * Apache Iceberg Tables | ||
| * [Configuration](./apache-iceberg.md) | ||
| * [Configuration](./Apache-Iceberg/Apache-Iceberg.md) |
Collaborator
There was a problem hiding this comment.
Did you also want to add Bauplan to the readme list? I see it mentioned in the PR description.
Collaborator
|
Something got messed up with renaming/trying to switch back. I tried to update this branch, made things worse, and ended up opening a new branch with the Bauplan changes. 🤦 If you could review #2755 to make sure it still captures everything you wanted to add @SeanWhelan I'd appreciate it. Sorry about that. |
Collaborator
|
Changes merged in #2755 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
materialize-bauplan), a variant of the Iceberg connectorWorkflow steps:
N/A
Documentation links affected:
Notes for reviewers:
Bauplan docs page is intentionally minimal so as not to duplicate existing Iceberg docs & Bauplan guide.