Skip to content

Emscripten build (aka too much webdev part 2)#27

Open
sppmacd wants to merge 15 commits intomainfrom
emscripten2
Open

Emscripten build (aka too much webdev part 2)#27
sppmacd wants to merge 15 commits intomainfrom
emscripten2

Conversation

@sppmacd
Copy link
Copy Markdown
Collaborator

@sppmacd sppmacd commented Jul 29, 2023 •
edited
Loading

image

As a bonus, fix some annoying red wiggles shown by clang(d).

You can use this code to test it (place in your binary dir):

<!DOCTYPE html>
<html lang="en-us">
  <head>
    <meta charset="utf-8" />
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
    <title>Emscripten-Generated Code</title>
    <style>
      body {
        margin: 0;
      }
      canvas {
        position: absolute;
        height: 100%;
        width: 100%;
      }
    </style>
  </head>
  <body>
    <canvas id="canvas" tabindex="-1" oncontextmenu="e.preventDefault()"> </canvas>

    <script type="text/javascript">
      function createCanvas() {
        var canvas = document.querySelector("canvas");

        // As a default initial behavior, pop up an alert when webgl context is lost. To make your
        // application robust, you may want to override this behavior before shipping!
        // See http://www.khronos.org/registry/webgl/specs/latest/1.0/#5.15.2
        canvas.addEventListener(
          "webglcontextlost",
          (e) => {
            alert("WebGL context lost. You will need to reload the page.");
            e.preventDefault();
          },
          false
        );

        return canvas;
      }

      var Module = {
        preRun: [],
        postRun: [],
        print: (function () {
          return function (text) {
            if (arguments.length > 1)
              text = Array.prototype.slice.call(arguments).join(" ");
            // These replacements are necessary if you render to raw HTML
            //text = text.replace(/&/g, "&amp;");
            //text = text.replace(/</g, "&lt;");
            //text = text.replace(/>/g, "&gt;");
            //text = text.replace('\n', '<br>', 'g');
            console.log(text);
          };
        })(),
        canvas: createCanvas(),
        setStatus: (text) => {
          console.log("Status");
        },
      };
    </script>
    <script async src="examples/essa-gui-text-editor.js"></script>
  </body>
</html>

TODO (not this PR):

  • fix some CMake hacks
  • make closing dialogs properly return to a main loop (requires The Dialog Refactoring #28 p. 6)
  • fix multiple shaders (will require API changes because of layout(location) not supported on WebGL ??)
  • CI workflow

@sppmacd sppmacd force-pushed the emscripten2 branch 3 times, most recently from ac19df0 to 84b8d18 Compare August 2, 2023 13:12
@sppmacd sppmacd requested a review from Adam-Ratajczak August 2, 2023 13:15
@sppmacd sppmacd marked this pull request as draft August 2, 2023 13:24
sppmacd added 13 commits August 6, 2023 21:02
@sppmacd
GUI: Use Util::Overloaded everywhere
d8c3bd9
@sppmacd
Util: Add explicit constructors for templated classes
bdfe17e 
Clang fails to deduce template params from aggregated init.
@sppmacd
LLGL: Change class->struct in forward declaration
67a474d 
Fixes clang complaining about something ABI
@sppmacd
Build: Use GCC-specific options only on GCC
af4f3ba 
Fixes -Wunknown-warning-option error on Clang.
@sppmacd
LLGL/OpenGL: Cleanup FBO construction
cde2ebd 
- Change some functions & constants to these available on GLES3
- Assign depth renderbuffer to framebuffer in correct place (Not
tested but previously it didn't make sense!)
- Don't create fbo scope if not resizing
- Add comments in FBO::resize()
@sppmacd
GUI: Remove unused variable
6bfebb5
@sppmacd
GUI: Workaround -Wpotentially-evaluated-expression in Container
41efca3 
Fixes build on Clang (and annoying red wiggles in editor)
@sppmacd
LLGL: Display error message when IMG_Load fails
95e149a
@sppmacd
LLGL: Use UNSIGNED_BYTE as texture type
2b3f846 
It is supported on GLES3, unlike FLOAT.
@sppmacd
Util: Don't use lexicographical_compare_three_way on clang
d1d518d 
It is not supported apparently (or at least compilation fails for me)
@sppmacd
Util: Define M_PIf on platforms that don't have it
a592e53 
This is a GCC extension
@sppmacd
Util: Use int instead of error_t
d6382f8 
error_t is a GCC extension (?)
@sppmacd
GUI: Reuse DefaultGUIShader for every Builder
6e6a24e 
This optimization is actually a hack to make dialogs work on Emscripten.
@sppmacd
LLGL+GUI+Build: Start working on Emscripten support
a8e06ba 
Things left to do:
- port all shaders to GLES (Basic and Lighting are left)
- async dialogs (part of The Dialog Refactoring #28)

This is not ideal:
- there is a fmt include hack
- threading is not implemented (is it even supported?)
- passthrough example is not included as it requires direct X11
- multiple windows don't work (this is Emscripten limitation)
@sppmacd sppmacd marked this pull request as ready for review August 6, 2023 19:34
@sppmacd
Util: Ignore -Waddress in Is.hpp
aedc1b1 
This fails to compile on GCC 12 for some reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Adam-Ratajczak Adam-Ratajczak Awaiting requested review from Adam-Ratajczak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sppmacd