Skip to content

Drop ciso646 deprecated header#600

Merged
bluescarni merged 4 commits intoesa:masterfrom
jschueller:ciso646
Apr 15, 2025
Merged

Drop ciso646 deprecated header#600
bluescarni merged 4 commits intoesa:masterfrom
jschueller:ciso646

Conversation

@jschueller
Copy link
Copy Markdown
Contributor

@jschueller jschueller commented Apr 10, 2025

Else I get a warning with gcc 15:

/usr/include/c++/15/ciso646:46:4: warning: #warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" [-Wcpp]
   46 | #  warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros"

I checked including vector instead also yields the _LIBCPP_VERSION macro with clang/libc++

Also fixes the doc CI job

@jschueller jschueller marked this pull request as draft April 10, 2025 09:01
@jschueller jschueller changed the title Only include deprecated header ciso646 if necessary Drop ciso646 deprecated header Apr 10, 2025
@jschueller jschueller marked this pull request as ready for review April 10, 2025 09:05
@jschueller
Copy link
Copy Markdown
Contributor Author

/cc @bluescarni

@bluescarni
Copy link
Copy Markdown
Member

Thanks @jschueller !

The idea with ciso646 was to include the lightest possible header that would allow us to detect the standard library version. Had no idea this was being deprecated...

@bluescarni bluescarni merged commit b653312 into esa:master Apr 15, 2025
8 checks passed
@jschueller jschueller deleted the ciso646 branch April 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants