Conversation
gomezzz
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces changes to improve data type handling and normalization methods in the image processing pipeline, as well as updates unit tests to accommodate these enhancements. The main focus is on ensuring that the output data type is determined by configuration and that normalization methods are correctly mapped.
Data type handling improvements:
apply_normalisationincutana/image_processor.pyto set the output data type based onconfig.data_type, defaulting tofloat32if the type is unknown. This ensures flexibility and correctness in image normalization output.Normalization method mapping:
convert_cfg_to_fitsbolt_cfg(cutana/normalisation_parameters.py) to usefitsbolt.NormalisationMethod.LINEARinstead ofCONVERSION_ONLY, aligning with expected fitsbolt behavior.Unit test updates:
test_combine_channels_simpleandtest_combine_channels_equal_weights(tests/cutana/unit/test_image_processor.py) to accept bothnp.float32andnp.float64as valid output types, reflecting the new data type handling logic. [1] [2]Test Plan: